End to end implementation of big keys from metrics, to server and to …#376
Merged
Conversation
Signed-off-by: nassery318 <nassery318@gmail.com>
ravjotbrar
reviewed
Jun 24, 2026
… Big Keys flow Signed-off-by: nassery318 <nassery318@gmail.com>
ravjotbrar
reviewed
Jun 25, 2026
ravjotbrar
left a comment
ravjotbrar
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks good. I would recommend making big keys configurable similar to other activity results.
|
|
||
| if (status === "Pending") return <LoadingState message="Scanning for big keys..." /> | ||
|
|
||
| const sorted = R.sort<BigKey>( |
Collaborator
There was a problem hiding this comment.
I'd probably swap sorted and filtered, so you sort what's filtered first. For 50 keys it's not a big deal but I imagine we'll be asked to make 50 configurable (to a much larger number)
Contributor
Author
There was a problem hiding this comment.
Good point! now we filter first and only sort the matching results, so we avoid sorting the whole dataset.
arseny-kostenko
previously approved these changes
Jun 25, 2026
Signed-off-by: nassery318 <nassery318@gmail.com>
arseny-kostenko
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…frontend
Description
Complete implementation of Big Keys flow from Metrics layer to Server and all the way to Fronted.
Screen.Recording.2026-06-24.at.10.37.45.AM.mov
Include a summary of the change.
Change Visualization
Include a screenshot/video of before and after the change.
https://github.com/user-attachments/assets/2f485d07-045c-4dd3-8d4c-7a97bfad3a81