Improve error handling for unsupported server commands#373
Merged
Conversation
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
ArgusLi
previously approved these changes
Jun 22, 2026
ArgusLi
left a comment
Contributor
There was a problem hiding this comment.
Just a small question. I like the way init-collectors works way more now.
Signed-off-by: ravjotb <ravjot.brar@improving.com>
ArgusLi
reviewed
Jun 22, 2026
| }, | ||
| }) | ||
|
|
||
| monitorStopper = async () => { |
Contributor
There was a problem hiding this comment.
Does this split from a singular updateCollectorMeta to 2 updateCollectorMetas have any upstream impact? Is there a reason why this needed to be split?
Collaborator
Author
There was a problem hiding this comment.
Good question. I split runMonitorOnce into two separate functions because I needed a way to return immediately if the monitor command wasn't supported. Before the code would need to await the entire duration of monitor for runMonitorOnce to return. Now we can await connectMonitor for an immediate result.
Signed-off-by: Ravjot Brar <83892020+ravjotbrar@users.noreply.github.com>
Signed-off-by: ravjotb <ravjot.brar@improving.com>
ArgusLi
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
When connecting to a server that doesn't support certain commands (e.g., ElastiCache
Serverless), Valkey Admin previously showed confusing errors, blank UI states, or
falsely reported features as active. This PR surfaces clear error messages to the user
and adds a connection-time warning for serverless caches.
Problem
unsupported
Changes
reporting "running." If the command is rejected, the error propagates to the frontend
and displays in the Activity view.
error response instead of crashing when the collector never initialized. Fixed a key
mismatch between the request type and collector name that caused the error check to be
bypassed.
warns the user which features are unavailable.
instead of retrying indefinitely.