You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FORCE_COLOR=true npx ava test/error-overview.tsx --serial
FORCE_COLOR=true npx ava test/errors.tsx test/error-overview.tsx --serial
npm run typecheck
npm run lint (passes with existing warnings in unrelated files)
npm run build
git diff --check
Note: I also ran npm test; it reached the broad AVA suite but failed in unrelated existing tests (alternate-screen-example, cursor, and measure-element) outside the touched ErrorOverview surface.
This still misses named native frames. I manually checked parseLine(' at foo (native)'), and it returns {native: true, function: 'foo'}. Since function is present, the new guard takes the structured frame path even though there is no file, line, or column.
Rendering that stack line currently produces - foo (::), and the aria label includes line undefined column undefined.
I think the guard should treat frames without source location data as incomplete too, not just frames where both file and function are missing. Otherwise this fix covers at native, but not at foo (native).
Updated this PR to handle named native frames like at foo (native) as incomplete stack frames too, so they render as the original raw stack line instead of foo (::) / undefined source-location metadata.
Local verification:
npm run typecheck ✅
npx xo src/components/ErrorOverview.tsx test/error-overview.tsx ✅
FORCE_COLOR=true npx ava test/error-overview.tsx ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stack-utilsincomplete stack frames (for exampleat native) as raw stack lines instead of structured frames withundefinedfields.ErrorOverviewregression coverage for native frames and repeated blank stack lines.Closes #963
Test Plan
FORCE_COLOR=true npx ava test/error-overview.tsx --serialFORCE_COLOR=true npx ava test/errors.tsx test/error-overview.tsx --serialnpm run typechecknpm run lint(passes with existing warnings in unrelated files)npm run buildgit diff --checkNote: I also ran
npm test; it reached the broad AVA suite but failed in unrelated existing tests (alternate-screen-example,cursor, andmeasure-element) outside the touched ErrorOverview surface.