refactor: align icon on the baseline, force it to be a flex container #10619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
requested changes
Dec 11, 2025
Member
web-padawan
left a comment
web-padawan
left a comment
There was a problem hiding this comment.
Tests are failing as there are some hardcoded values e.g. for ::before pseudo-element height:
❌ vaadin-icon - icon fonts > sizing > should have the same height as the host
AssertionError: expected 36 to be close to 24 +/- 1
at n.<anonymous> (packages/icon/test/icon-font.test.js:26:52)
❌ vaadin-icon - icon fonts > sizing > should not overflow host - line height
AssertionError: expected 36 to be close to 24 +/- 1
at n.<anonymous> (packages/icon/test/icon-font.test.js:47:52)
❌ vaadin-icon - icon fonts > sizing > should subtract vertical padding from height
AssertionError: expected 26 to be close to 14 +/- 1
at n.<anonymous> (packages/icon/test/icon-font.test.js:62:72)
web-padawan
reviewed
Dec 11, 2025
jouni
commented
Dec 11, 2025
web-padawan
approved these changes
Dec 16, 2025
web-padawan
changed the title
|
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
web-padawan
pushed a commit
that referenced
this pull request
Dec 16, 2025
…#10619) (#10679) Co-authored-by: Jouni Koivuviita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align icons on baseline instead of middle of the line-box. Remove slotted styles, always force the icon to be a flex container.
Fixes #10583 for SVG icons in all themes and for font icons in the built-in themes (Aura and Lumo).