refactor: remove getComputedStyle check for colorIndex validation #10300
+3
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jouni
approved these changes
Oct 9, 2025
sissbruecker
approved these changes
Oct 9, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-beta2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The avatar's colorIndex property validation was necessary when the corresponding CSS properties were shipped only as part of the Lumo and Material themes and weren't available in the base styles. Since these properties are now included in the base styles, the warning is no longer well justified. Considering that it requires a
getComputedStyle()call, which can have a significant performance impact as shown below, it's better to remove it altogether.Performance measurements were taken with a 4x CPU throttle on
dev/aura.html.Type of change