Skip to content

Conversation

@vaadin-bot
Copy link
Collaborator

No description provided.

* fix: Remove click() from CheckboxTester
* Override inherited click method to toggle checkbox value using setValueAsUser
@mshabarov mshabarov requested a review from mcollovati November 17, 2025 12:54
@mcollovati
Copy link
Contributor

@TatuLund the change cannot be picked as-is because it requires #2012 that in turn cannot be backported as it is a breaking change.

I guess we just need to remove the @Override annotation and add again the click() method implemented as

    public void click() {
        click(0, new MetaKeys());
    }

Same goes for #2081

@TatuLund
Copy link
Contributor

Yes, I noticed it too when CP failed

Refactor click method to simplify interaction with Checkbox component.
Added imports for ClickEvent and ComponentUtil.
@mcollovati mcollovati enabled auto-merge (squash) November 20, 2025 08:16
@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Test Results

  154 files  ±0    154 suites  ±0   16m 54s ⏱️ + 1m 42s
1 132 tests ±0  1 126 ✅ ±0  6 💤 ±0  0 ❌ ±0 
1 502 runs  ±0  1 496 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit b6bfd03. ± Comparison against base commit c2d8793.

♻️ This comment has been updated with latest results.

@mcollovati mcollovati merged commit 87eb360 into 9.5 Nov 20, 2025
5 of 6 checks passed
@mcollovati mcollovati deleted the cherry-pick-2079-to-9.5-1763366702205 branch November 20, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants