test: verify storybook-oversight workflow fix (throwaway, do not merge) - #1586
test: verify storybook-oversight workflow fix (throwaway, do not merge)#1586jordmccord wants to merge 5 commits into
Conversation
…e run" Both workflows only declared a pull_request trigger, but something forces them to also run on push (confirmed via the Actions API: every recent run has event=push and 0 jobs). Since push never matches a pull_request-only trigger, every commit produced a zero-job failing run and an email. Add a push trigger and move the packages/react(-native)/** path check from the trigger-level paths filter into an in-job dorny/paths-filter step, gating the build/lint steps on its output. This guarantees a job always registers while still skipping the expensive work when unrelated files change.
Throwaway PR to confirm the push-triggered runs of react-storybook-oversight.yml / react-native-storybook-oversight.yml report a skipped job instead of failing with "No jobs were run". Safe to close without merging.
|
There was a problem hiding this comment.
🟡 Changes recommended
The README change is explicitly temporary test-only content and should be removed to avoid accidentally landing documentation noise.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR is a throwaway change intended to trigger/validate the fixed Storybook oversight GitHub Actions workflows (from #1585) by creating a PR run that should register jobs (with relevant steps skipped due to no packages/react/** or packages/react-native/** changes).
Changes:
- Add a temporary HTML comment to
README.mdto create a no-op commit for workflow verification.
File summaries
| File | Description |
|---|---|
| README.md | Adds a temporary marker comment to generate a PR run for validating the Storybook oversight workflow behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <!-- test PR: verifying storybook-oversight workflow fix, safe to close/discard --> | ||
|
|
||
|
|
…ths-filter Per Copilot review on #1585: dorny/paths-filter needs pull-requests:read to query PR diffs on pull_request events, and the default checkout fetch-depth of 1 is often insufficient for it to compute the diff/merge base reliably on push events. Bump to fetch-depth: 20.
…ify-storybook-oversight-fix
|
Closing this throwaway verification PR — turned out we can't actually validate the push-triggered path from a branch/PR at all (see #1585 for the full writeup). Not merging. |
Throwaway PR to verify the fix in #1585 — this branch is off
fix/storybook-oversight-no-jobs-were-runso both updated workflows are in effect here.Expected:
React Storybook OversightandReact Native Storybook Oversightchecks should each show a job that ran (with the build/lint steps skipped, since this change doesn't touchpackages/react/**orpackages/react-native/**) — not "No jobs were run".Do not merge — will be closed once verified.