Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
byok openai embeddings added #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
byok openai embeddings added #248
Changes from all commits
15da62dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Locally loaded index not refreshed after
:addcommandAfter
setup()callsself.moss.load_index(self.index_name)atexamples/python/byok_oai.py:92orexamples/python/byok_oai.py:126, all subsequent queries route through the local in-memory index (seesdks/python/sdk/src/moss/client/moss_client.py:198-201). Theaddmethod atexamples/python/byok_oai.py:168-179callsadd_docswhich sends the document to the cloud, but never reloads the local index. This means documents added via:addduring the REPL session won't appear in subsequent query results until the process is restarted. The in-memoryself.docscache is updated (so:listand:countreflect the addition), which could mislead users into thinking the doc is searchable. This is an inherent architectural characteristic (mutations go to cloud, local index is a snapshot), but worth noting for an interactive demo that invites users to add and immediately search.Was this helpful? React with 👍 or 👎 to provide feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.