Skip to content

build(deps): bump secp256k1 from 0.30.0 to 0.31.1 #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2025
+10 −14
Merged

build(deps): bump secp256k1 from 0.30.0 to 0.31.1 #2705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f525b91
build(deps): bump secp256k1 from 0.30.0 to 0.31.1
dependabot[bot] Nov 25, 2025
1b7f519
Merge branch 'master' into dependabot/cargo/secp256k1-0.31.1
cmichi Nov 26, 2025
275bbc1
Merge remote-tracking branch 'origin/master' into dependabot/cargo/se…
cmichi Nov 30, 2025
86d4daa
Fix upgrade
cmichi Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ scale-decode = { version = "0.16.0", default-features = false }
scale-encode = { version = "0.10.0", default-features = false }
scale-info = { version = "2.11", default-features = false }
schemars = { version = "0.8" }
secp256k1 = { version = "0.30.0" }
secp256k1 = { version = "0.31.1" }
serde = { version = "1.0.215", default-features = false }
serde_json = { version = "1.0.145" }
sha2 = { version = "0.10" }
Expand Down
6 changes: 2 additions & 4 deletions crates/engine/src/ext.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,14 +409,12 @@ impl Engine {
let recovery_id = RecoveryId::try_from(recovery_byte as i32)
.unwrap_or_else(|error| panic!("Unable to parse the recovery id: {error}"));

let message = Message::from_digest_slice(message_hash).unwrap_or_else(|error| {
panic!("Unable to create the message from hash: {error}")
});
let message = Message::from_digest(*message_hash);
let signature =
RecoverableSignature::from_compact(&signature[0..64], recovery_id)
.unwrap_or_else(|error| panic!("Unable to parse the signature: {error}"));

let pub_key = SECP256K1.recover_ecdsa(&message, &signature);
let pub_key = SECP256K1.recover_ecdsa(message, &signature);
match pub_key {
Ok(pub_key) => {
*output = pub_key.serialize();
Expand Down
6 changes: 3 additions & 3 deletions crates/engine/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,10 @@ fn ecdsa_recovery_with_secp256k1_crate() {
let mut msg_hash = [0; 32];
crate::hashing::sha2_256(b"Some message", &mut msg_hash);

let msg = Message::from_digest_slice(&msg_hash).expect("message creation failed");
let seckey = SecretKey::from_slice(&seckey).expect("secret key creation failed");
let msg = Message::from_digest(msg_hash);
let seckey = SecretKey::from_byte_array(seckey).expect("secret key creation failed");
let recoverable_signature: RecoverableSignature =
SECP256K1.sign_ecdsa_recoverable(&msg, &seckey);
SECP256K1.sign_ecdsa_recoverable(msg, &seckey);

let recovery_id: i32 = recoverable_signature.serialize_compact().0.into();
let recovery_id = recovery_id as u8;
Expand Down
6 changes: 2 additions & 4 deletions crates/env/src/engine/off_chain/impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,14 +500,12 @@ impl EnvBackend for EnvInstance {
};
let recovery_id = RecoveryId::try_from(recovery_byte as i32)
.unwrap_or_else(|error| panic!("Unable to parse the recovery id: {error}"));
let message = Message::from_digest_slice(message_hash).unwrap_or_else(|error| {
panic!("Unable to create the message from hash: {error}")
});
let message = Message::from_digest(*message_hash);
let signature =
RecoverableSignature::from_compact(&signature[0..64], recovery_id)
.unwrap_or_else(|error| panic!("Unable to parse the signature: {error}"));

let pub_key = SECP256K1.recover_ecdsa(&message, &signature);
let pub_key = SECP256K1.recover_ecdsa(message, &signature);
match pub_key {
Ok(pub_key) => {
*output = pub_key.serialize();
Expand Down
Loading