Closed
Conversation
Contributor
Author
|
Notably the resumption is in |
Contributor
Author
|
In testing both your and my branches kill the process on |
dozreg-toplud
force-pushed
the
dozreg/windows-setjmp
branch
from
3dcafb7 to
814089b
Compare
Contributor
Author
|
Both branches were killing the process with optimizations enabled, on debug both worked. That led me to believe it's the register allocation. I tried calling the intrinsic with the goal of clobbering all registers, which did not work for some reason. Then I added manual clobbering of all callee-saved registers (caller-saved registers are already clobbered by calling |
dozreg-toplud
changed the title
Contributor
Author
|
Added register clobbering after longjmp as well as before setjmp. Tested on vere64, seems to work |
Contributor
Author
|
This is rendered obsolete by #987 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per docs:
Maybe we should still call the builtin just to signal to the compiler that the registers ought to be saved?