conn: optionally deliver channel response after EOF on read#981
Merged
conn: optionally deliver channel response after EOF on read#981
Conversation
Conn protocol closes the channel as soon as an EOF is received from a read request. This is at odds with a typical usage of conn, where separate programs are used to send a command and receive a result. We modify this behavior by calling moat `bal_f` only on genuine read errors. Furthermore, in conn.c we close the channel after processing the effect if we detect that the read end of the pipe has closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes and supersedes #892, ensuring no behavior change for mars/urth IPC pipe.