Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new OneOf assert to the validator.js-asserts package, along with exports, TypeScript typings, and tests to validate behavior.
Changes:
- Added
OneOfassert implementation (src/asserts/one-of-assert.js) and exported it fromsrc/index.js. - Added TypeScript definition for
oneOf(...)insrc/types/index.d.ts. - Updated test suite to include
OneOfin the export list and added dedicatedOneOftests.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/index.test.js | Updates the expected exported assert count and list to include OneOf. |
| test/asserts/one-of-assert.test.js | Adds unit tests covering OneOf validation and violation aggregation behavior. |
| src/types/index.d.ts | Adds the oneOf(...constraintSets) TypeScript API definition. |
| src/index.js | Exports the new OneOf assert from the package entry point. |
| src/asserts/one-of-assert.js | Implements OneOf validation against multiple constraint sets using validator.js constraints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
52d45c3 to
ffc4601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new assert to allow one of constraints (1 exclusive match)
Added this here because https://github.com/uphold/paypal-client/pull/60 required this type of validation to have more readable code