Conversation
Signed-off-by: Rafael Santos <rafael.santos@uphold.com>
There was a problem hiding this comment.
Pull request overview
This PR transitions the repository’s tooling from Yarn to npm (targeting npm v12), updating CI workflows and project metadata to reflect the new package manager and adding a CI status badge to the README.
Changes:
- Remove
yarn.lockand update GitHub Actions workflows to usenpm ci/npm run …instead ofyarn …, while pinning actions to commit SHAs. - Add
devEngines.packageManager(npm v12) and anallowScriptsentry topackage.json. - Add a CI tests status badge to
README.md.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Removed Yarn lockfile as part of the migration away from Yarn. |
package.json |
Adds npm v12 package manager metadata and allowScripts configuration. |
.github/workflows/tests.yaml |
Switch CI install/lint/test steps from Yarn to npm and pin GitHub Actions by SHA. |
.github/workflows/release.yaml |
Switch release workflow dependency installation from Yarn to npm and pin GitHub Actions by SHA. |
README.md |
Adds a CI test status badge. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
16
to
20
| - name: Setup Node.js version | ||
| uses: actions/setup-node@v6 | ||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version: ${{ matrix.node }} | ||
| cache: 'yarn' | ||
|
|
Comment on lines
33
to
+40
| - name: Set up Node.js version | ||
| uses: actions/setup-node@v6 | ||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version: 24 | ||
| registry-url: 'https://registry.npmjs.org/' | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
| run: npm ci |
Signed-off-by: Rafael Santos <rafael.santos@uphold.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Transition the project from using yarn to NPM v12 as package manager.
devEngines.packageManagertopackage.json, which will also enable automatic dependency caching on CI viaactions/setup-node.@fastify/pre-committoallowScripts.install-strategytolinked, as recommended on their docs.See https://docs.npmjs.com/cli/v12/commands/npm-install#install-strategy.