Skip to content

Conversation

@SimonFair
Copy link
Contributor

@SimonFair SimonFair commented Jan 23, 2026

Summary by CodeRabbit

  • Chores
    • Expanded PR workflow to monitor additional directory paths so more changes trigger builds.
    • Adjusted build packaging to include the entire build output directory rather than a limited subtree.
    • Standardized the workflow message when no changed files are detected.

✏️ Tip: You can customize this high-level summary in your review settings.

@SimonFair SimonFair requested a review from elibosley January 23, 2026 11:06
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

Walkthrough

A GitHub Actions PR workflow was updated: trigger paths were extended to include etc/, sbin/, and share/; the changed-files message was generalized; file discovery now uses find . -type f and the tar step archives the entire current directory (tar -czf ... .) instead of usr/.

Changes

Cohort / File(s) Summary
Workflow triggers
.github/workflows/pr-plugin-build.yml
Added additional watched paths (etc/, sbin/, share/) to PR-triggered checks; broadened change-detection message from "No emhttp files changed" to "No files changed".
Workflow tarball packaging
.github/workflows/pr-plugin-build.yml
Changed file discovery from find usr/ -type f to find . -type f; changed tar creation from archiving usr/ to archiving . (tar -czf ... .), packaging the full repository working directory.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I munched through folders, wide and dotty,
I sniffed etc, sbin, share—oh what a party!
From usr/ to . the bundle grew,
Every hidden leaf and file joined too. 📦✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main fix: expanding tar's packaging scope to include new files (etc/, sbin/, share/) that were previously not being picked up.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@elibosley elibosley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimonFair SimonFair merged commit 0872e5b into unraid:master Jan 23, 2026
2 checks passed
@SimonFair SimonFair mentioned this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants