feat(metadata): Add TypeScript and JavaScript package managers

[JayGhiya]

User description

Extend programming language and package manager metadata to
support TypeScript and JavaScript ecosystem. This includes
adding TypeScript as a language and introducing popular
JavaScript package managers like npm, yarn, pnpm, and bun.

---

PR Type

Enhancement

---

Description

• Add TypeScript language support to programming language metadata

• Extend package manager types with JavaScript ecosystem tools

• Include npm, yarn, pnpm, and bun package managers

• Minor formatting fix for trailing newline

---

Diagram Walkthrough

flowchart LR
  A["ProgrammingLanguage enum"] --> B["Add TYPESCRIPT"]
  C["PackageManagerType enum"] --> D["Add NPM, YARN, PNPM, BUN"]
  E["repo_models.py"] --> F["Fix trailing newline"]

Loading

File Walkthrough

	Relevant files
Enhancement	programming_language_metadata.py Extend metadata with TypeScript and JS package managers    unoplat-code-confluence-commons/src/unoplat_code_confluence_commons/programming_language_metadata.py Add TYPESCRIPT to ProgrammingLanguage enum Add four JavaScript package managers to PackageManagerType enum: NPM, YARN, PNPM, BUN +5/-0
Formatting	repo_models.py Fix trailing newline formatting                                                    unoplat-code-confluence-commons/src/unoplat_code_confluence_commons/repo_models.py Add missing newline at end of file +1/-1

---

[huly-for-github]

Connected to Huly®: UNOPL-1020

[claude]

Claude finished @JayGhiya's task —— View job

---

Code Review Complete ✅

Todo List

• Read and analyze changed files
• Review enum additions for consistency and best practices
• Check for potential bugs or issues
• Assess performance and security considerations
• Evaluate test coverage requirements
• Provide comprehensive feedback

---

Review Summary

This PR adds TypeScript language support and JavaScript ecosystem package managers to the codebase metadata. The changes are minimal, focused, and follow existing patterns well.

✅ Strengths

1. Consistent Implementation: The enum additions follow the exact same pattern as existing entries
2. Proper Scope: Changes are limited to metadata definitions without breaking existing functionality
3. Clean Implementation: Simple enum additions without complex logic changes
4. Formatting Fix: Includes a minor but helpful trailing newline fix

🔧 Issues Found & Recommendations

Critical: Incomplete Implementation

The enum additions are only half of the implementation needed:

In programming_language_metadata.py:26-30:

_strategies: Dict[Tuple[ProgrammingLanguage, PackageManagerType], type[PackageManagerStrategy]] = {
    (ProgrammingLanguage.PYTHON, PackageManagerType.POETRY): PythonPoetryStrategy,
    (ProgrammingLanguage.PYTHON, PackageManagerType.PIP): PipStrategy,
    (ProgrammingLanguage.PYTHON, PackageManagerType.UV): UvStrategy,
}

Missing: Strategy implementations for the new package managers. Without these, the new enum values will cause UnsupportedPackageManagerError when used.

In programming_language_metadata.py:33-37:

_manager_name_to_type: Dict[str, PackageManagerType] = {
    "poetry": PackageManagerType.POETRY,
    "pip": PackageManagerType.PIP,
    "uv": PackageManagerType.UV,
}

Missing: Mappings for npm, yarn, pnpm, bun in the name-to-type dictionary.

Consistency Issue: Frontend Alignment

The frontend already expects these package managers (types.ts:268-275):

export const LANGUAGE_PACKAGE_MANAGERS: Record<string, string[]> = {
  python: ['uv', 'pip', 'poetry'],
  javascript: ['npm', 'yarn', 'pnpm'],  // ← Already expects these
  typescript: ['npm', 'yarn', 'pnpm'],  // ← Already expects these
  // ...
};

This suggests the frontend was built expecting this backend support.

🧪 Test Coverage Assessment

Current State: No dedicated tests found for programming language metadata enums.

Recommendation: While enum additions are low-risk, consider adding basic validation tests:

def test_typescript_language_enum():
    assert ProgrammingLanguage.TYPESCRIPT == "typescript"

def test_javascript_package_managers():
    assert PackageManagerType.NPM == "npm"
    assert PackageManagerType.YARN == "yarn"
    # etc.

🚀 Performance & Security

• Performance: ✅ No impact - simple enum additions
• Security: ✅ No concerns - metadata-only changes

📋 Next Steps Needed

To make this PR production-ready, you'll need:

1. Add Package Manager Strategies: Implement NpmStrategy, YarnStrategy, PnpmStrategy, BunStrategy classes
2. Update Factory Mappings: Add the new managers to PackageManagerStrategyFactory._manager_name_to_type
3. Register Strategy Combinations: Add (TYPESCRIPT, NPM) etc. combinations to _strategies
4. Add Detection Logic: Implement detection for package.json, yarn.lock, etc.

💡 Suggestion

Consider splitting this into two PRs:

1. Current PR: Enum definitions (this PR) - can be merged as foundation
2. Follow-up PR: Complete implementation with strategies and detection

This allows the metadata foundation to be established while the implementation is developed separately.

---

Overall Assessment: Good foundation work that follows existing patterns. The enum additions are correct and safe to merge, but incomplete for end-to-end functionality.

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
⚪	No custom compliance provided Follow the guide to enable custom compliance check.

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Add JavaScript to programming languages Add JAVASCRIPT to the ProgrammingLanguage enum to align with the addition of JavaScript-related package managers like npm and yarn. unoplat-code-confluence-commons/src/unoplat_code_confluence_commons/programming_language_metadata.py [7-9] class ProgrammingLanguage(str, Enum): PYTHON = "python" + JAVASCRIPT = "javascript" TYPESCRIPT = "typescript" Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies that while JavaScript package managers are being added, the JAVASCRIPT language itself is missing from the ProgrammingLanguage enum, which is a logical oversight.	Medium
More