fix: upgrade commons dependency to v0.47.0 (ingestion + query engine) - #1352
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughTwo Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @JayGhiya's task —— View job Code Review Complete ✅Review Tasks
Review SummaryThis PR successfully upgrades ✅ Positives
📝 Code Quality AssessmentFiles Changed:
Change Pattern: # Before (commented out local dev path)
#unoplat-code-confluence-commons = { path = "../../unoplat-code-confluence-commons" }
# After (pinned git source)
unoplat-code-confluence-commons = { git = "https://github.com/unoplat/unoplat-code-confluence.git", subdirectory = "unoplat-code-confluence-commons", rev = "unoplat-code-confluence-commons-v0.47.0" }🔒 Security & Best Practices
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@unoplat-code-confluence-ingestion/code-confluence-flow-bridge/pyproject.toml`:
- Around line 65-66: The dependency floor in project.dependencies must match the
pinned source rev in tool.uv.sources: change the unoplat-code-confluence-commons
version constraint in pyproject.toml (under project.dependencies) from
">=0.24.0" (or a wide range) to a minimum of ">=0.47.0" or pin to "==0.47.0" so
it aligns with the git rev "unoplat-code-confluence-commons-v0.47.0"; update the
entry for unoplat-code-confluence-commons in project.dependencies to use the new
constraint to ensure reproducible installs.
In `@unoplat-code-confluence-query-engine/pyproject.toml`:
- Around line 56-57: The declared dependency range for
unoplat-code-confluence-commons in project.dependencies is inconsistent with the
git source pin (rev "unoplat-code-confluence-commons-v0.47.0"); update the
dependency spec for the symbol "unoplat-code-confluence-commons" in
pyproject.toml (the entry under project.dependencies) to require at least 0.47.0
(e.g., change ">=0.25.0" to ">=0.47.0") so the minimum allowed version aligns
with the pinned source revision.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3ed0a9e0-471e-4f56-a478-0f6f6a0d2931
⛔ Files ignored due to path filters (2)
unoplat-code-confluence-ingestion/code-confluence-flow-bridge/uv.lockis excluded by!**/*.lockunoplat-code-confluence-query-engine/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
unoplat-code-confluence-ingestion/code-confluence-flow-bridge/pyproject.tomlunoplat-code-confluence-query-engine/pyproject.toml
| #unoplat-code-confluence-commons = { path = "../../unoplat-code-confluence-commons" } | ||
| unoplat-code-confluence-commons = { git = "https://github.com/unoplat/unoplat-code-confluence.git", subdirectory = "unoplat-code-confluence-commons", rev = "unoplat-code-confluence-commons-v0.47.0" } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n unoplat-code-confluence-ingestion/code-confluence-flow-bridge/pyproject.toml | head -80Repository: unoplat/unoplat-code-confluence
Length of output: 3012
🏁 Script executed:
find . -name "dependencies_overview.md" -o -name "*dependencies*" -type f | grep -i overview | head -20Repository: unoplat/unoplat-code-confluence
Length of output: 313
🏁 Script executed:
find unoplat-code-confluence-commons -name "*.md" | head -20Repository: unoplat/unoplat-code-confluence
Length of output: 371
🏁 Script executed:
rg "unoplat-code-confluence-commons" --type md -A 2 -B 2 | head -50Repository: unoplat/unoplat-code-confluence
Length of output: 5436
🏁 Script executed:
find unoplat-code-confluence-ingestion -name "dependencies_overview.md" -o -name "*dependencies*" -type f | grep -E "(overview|dependencies)" | head -20Repository: unoplat/unoplat-code-confluence
Length of output: 383
🏁 Script executed:
cat unoplat-code-confluence-commons/dependencies_overview.md | head -100Repository: unoplat/unoplat-code-confluence
Length of output: 3266
🏁 Script executed:
find unoplat-code-confluence-ingestion -name "pyproject.toml" -exec grep -l "unoplat-code-confluence-commons" {} \;Repository: unoplat/unoplat-code-confluence
Length of output: 151
🏁 Script executed:
rg "unoplat-code-confluence-commons" unoplat-code-confluence-ingestion --type toml -A 1 -B 1Repository: unoplat/unoplat-code-confluence
Length of output: 2497
Update the commons version floor to match the v0.47.0 source pin.
This file pins commons to v0.47.0 in tool.uv.sources, but project.dependencies still allows >=0.24.0, which weakens reproducibility and compatibility guarantees.
Suggested fix
- "unoplat-code-confluence-commons>=0.24.0",
+ "unoplat-code-confluence-commons>=0.47.0",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@unoplat-code-confluence-ingestion/code-confluence-flow-bridge/pyproject.toml`
around lines 65 - 66, The dependency floor in project.dependencies must match
the pinned source rev in tool.uv.sources: change the
unoplat-code-confluence-commons version constraint in pyproject.toml (under
project.dependencies) from ">=0.24.0" (or a wide range) to a minimum of
">=0.47.0" or pin to "==0.47.0" so it aligns with the git rev
"unoplat-code-confluence-commons-v0.47.0"; update the entry for
unoplat-code-confluence-commons in project.dependencies to use the new
constraint to ensure reproducible installs.
| #unoplat-code-confluence-commons = { path = "../unoplat-code-confluence-commons" } | ||
| unoplat-code-confluence-commons = { git = "https://github.com/unoplat/unoplat-code-confluence.git", subdirectory = "unoplat-code-confluence-commons", rev = "unoplat-code-confluence-commons-v0.47.0" } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
python - <<'PY'
import tomllib, re
from pathlib import Path
files = [
Path("unoplat-code-confluence-query-engine/pyproject.toml"),
Path("unoplat-code-confluence-ingestion/code-confluence-flow-bridge/pyproject.toml"),
]
def parse_tuple(v: str):
return tuple(int(x) for x in v.split("."))
for p in files:
data = tomllib.loads(p.read_text())
dep = next(d for d in data["project"]["dependencies"] if d.startswith("unoplat-code-confluence-commons"))
rev = data["tool"]["uv"]["sources"]["unoplat-code-confluence-commons"]["rev"]
min_match = re.search(r">=\s*([0-9]+\.[0-9]+\.[0-9]+)", dep)
rev_match = re.search(r"v([0-9]+\.[0-9]+\.[0-9]+)", rev)
print(f"\n{p}")
print(f" dependency: {dep}")
print(f" source rev: {rev}")
if min_match and rev_match:
min_v = min_match.group(1)
rev_v = rev_match.group(1)
print(f" parsed min version: {min_v}")
print(f" parsed rev version: {rev_v}")
print(f" min version < rev version: {parse_tuple(min_v) < parse_tuple(rev_v)}")
PYRepository: unoplat/unoplat-code-confluence
Length of output: 605
Align the declared commons minimum version with the pinned source revision.
The source is pinned to v0.47.0, but project.dependencies declares >=0.25.0. This inconsistency can allow older commons versions to be resolved outside the uv source override.
Suggested fix
- "unoplat-code-confluence-commons>=0.25.0",
+ "unoplat-code-confluence-commons>=0.47.0",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@unoplat-code-confluence-query-engine/pyproject.toml` around lines 56 - 57,
The declared dependency range for unoplat-code-confluence-commons in
project.dependencies is inconsistent with the git source pin (rev
"unoplat-code-confluence-commons-v0.47.0"); update the dependency spec for the
symbol "unoplat-code-confluence-commons" in pyproject.toml (the entry under
project.dependencies) to require at least 0.47.0 (e.g., change ">=0.25.0" to
">=0.47.0") so the minimum allowed version aligns with the pinned source
revision.
1 participant
Summary
Upgrades
unoplat-code-confluence-commonsfromv0.46.0tov0.47.0in both services, switching from local path sources (dev mode) to pinned git sources (release mode).Changes
fix(common-version-ingestion): upgrade commons dependency to v0.47.0fix(common-version-query-engine): upgrade commons dependency to v0.47.0Summary by CodeRabbit