fix bug in UnisonFile.constructorsId - effects were treated as decls

[mitchellwrosen]

Overview

This PR fixes a bug I noticed in the implementation of UnisonFile.constructorsId. Effect constructors were erroneously classified as data constructors. This function is only used in the implementation of slurp, where the misclassification actually doesn't matter (we happen to treat data an effect constructors uniformly).

While in there I also micro-optimized a couple Map.union (Map.map ...) (Map.map ...) to use Map.merge instead.

Test coverage

No tests, just swapped a Right for a Left

[mitchellwrosen]

CI failure looks spurious:

wrong host example.com fails   Unexpected exception found HandshakeFailed (Error_Protocol ("expecting server hello, got alert : [(AlertLevel_Fatal,InternalError)]",True,HandshakeFailure))

[aryairani]

CI failure looks spurious:

wrong host example.com fails   Unexpected exception found HandshakeFailed (Error_Protocol ("expecting server hello, got alert : [(AlertLevel_Fatal,InternalError)]",True,HandshakeFailure))

Where does that error come from, I don't see it in the logs?

Any ideas as to why it might be failing in Linux only?

Can you re-run the failed jobs; let me know if there's any permissions issue.

[mitchellwrosen]

@aryairani re-ran and they succeeded. I have no clue about the error, just looked like a network blip.