Joss submission #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #303
…nderworld3 into joss-submission
typo in link
* uwmaster -> upstream * Specify underworld3
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request prepares the repository for JOSS (Journal of Open Source Software) submission by bringing changes from the joss-submission branch to dev. The main purpose is to update the submission materials and make the repository ready for re-submission as requested by the JOSS editor.
- Updates JOSS paper content with expanded mathematical framework and field comparison sections
- Enables previously disabled advection/diffusion tests with improved analytical solutions
- Prepares repository structure and metadata for JOSS requirements
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_1100_AdvDiffCartesian.py | Major refactor replacing 1D numerical comparison with analytical solution verification |
| test.sh | Re-enables previously commented out advection/diffusion test suites |
| src/underworld3/_version.py | Version bump from 0.98.1b to 0.99.0b with release preparation comment |
| paper.md | Creates symbolic link to actual JOSS paper location |
| paper.bib | Creates symbolic link to JOSS bibliography file |
| docs/user/NextSteps.qmd | Updates API documentation URL and fixes syntax |
| docs/joss-paper/paper.md | Extensive content updates including expanded mathematical framework |
| docs/joss-paper/paper.crossref | Updates timestamps and adds author affiliations |
| docs/joss-paper/paper.bib | Major bibliography expansion with corrected citation keys |
| docs/joss-paper/JOSS_Checklist.md | Updates checklist items to completed status |
| docs/developer/CodingStyle.md | Reformats text and adds clarification about pytest independence |
| README.md | Adds build status badge and formatting improvements |
| LICENCE.md | Corrects reference to license file name |
| CONTRIBUTING.md | Adds comprehensive contribution guidelines |
| .zenodo.json | Reorders authors and fixes JSON syntax |
| .github/workflows/draft-pdf.yml | Updates action version from v3 to v4 |
Co-authored-by: Copilot <[email protected]>
do not return from within a context manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the joss-submission information across to dev.
We will need to update the joss-submission branch to reflect the current state of the code (request from editor to re-submit)
L