Fixed some bugs those addressed on issue pages and added int1 alias as domain.#6
Open
krmgns wants to merge 17 commits intoumitanuki:masterfrom
Open
Fixed some bugs those addressed on issue pages and added int1 alias as domain.#6krmgns wants to merge 17 commits intoumitanuki:masterfrom
int1 alias as domain.#6krmgns wants to merge 17 commits intoumitanuki:masterfrom
Conversation
Owner
|
Thank you for PR! I am currently not maintaining the module actively, but I wish someone can take this over... |
Author
Hi there, I think I can do it. |
Dead2
reviewed
Feb 17, 2021
| EXTRA_CLEAN += $(SQL_IN) $(EXTSQL) $(EXTSQLTMP) | ||
|
|
||
| USE_EXTENSION = $(shell $(pg_config) --version | grep -qE " 8\.|9\.0" && echo no || echo yes) | ||
| USE_EXTENSION = $(shell pg_config --version | grep -qE " 8\.|9\.0" && echo no || echo yes) |
Contributor
There was a problem hiding this comment.
This does a partial revert of the changes in c47c39e, making it harder to compile this module for a non-default postgresql version.
Such as compiling for pgsql 10/11/12 from pgdg repos when the distro only provides postgresql 9.6 (Such as is the case for EL/Centos 7).
Author
There was a problem hiding this comment.
Sadly it did not work on Ubuntu and could not figure out in other way. I thing there need to be more if/else conditions.
|
Any activity here? |
Based on structure of https://github.com/ibarwick/firebird_fdw/blob/master/README.md
Documentation refactoring
Fix typo, add link to other implementation of 1b int
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
1- ERROR: could not find function information for function "bt_tinyint_i8_cmp" [#2]
2- No longer able to build on Postgresql 11, Ubuntu 18.04 [#4]