Speed up LeapImage by copying textures on the render thread#105
Open
diekleinekuh wants to merge 1 commit intoultraleap:mainfrom
Open
Speed up LeapImage by copying textures on the render thread#105diekleinekuh wants to merge 1 commit intoultraleap:mainfrom
diekleinekuh wants to merge 1 commit intoultraleap:mainfrom
Conversation
…es in UpdateTextureRegions call that freed memory it didn't own
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the images from the leap tracker in our app and copying the image data on game thread was too slow. So we found the deactivated code path and enabled it. After fixing the freeing of the image data in UpdateTextureRegions this worked well for us since a couple of month.