Skip to content

Create plasma rad class - #4695

Merged
je-cook merged 7 commits into
mainfrom
create_plasma_rad_class
Nov 4, 2026
Merged

je-cook merged 7 commits into
mainfrom
create_plasma_rad_class

Conversation

@chris-ashe

@chris-ashe chris-ashe commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Description

  • Move all radiation calcs into a new class called PlasmaRadiation.
  • Physics class now has composition with PlasmaRadiation
  • Dedicated output method now for radiation and is pulled from outplas()

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added Radiation Plasma radiated power Refactor labels Oct 16, 2026
@codecov-commenter

codecov-commenter commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 21.49533% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.36%. Comparing base (030521f) to head (94c33dd).

Files with missing lines Patch % Lines
process/models/physics/radiation_power.py 18.36% 80 Missing ⚠️
process/models/physics/physics.py 33.33% 2 Missing ⚠️
process/models/physics/impurity_radiation.py 66.66% 1 Missing ⚠️
process/models/stellarator/stellarator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4695      +/-   ##
==========================================
+ Coverage   50.27%   50.36%   +0.08%     
==========================================
  Files         181      181              
  Lines       30645    30666      +21     
==========================================
+ Hits        15407    15444      +37     
+ Misses      15238    15222      -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe
chris-ashe marked this pull request as ready for review October 16, 2026 11:08
@chris-ashe
chris-ashe requested a review from a team as a code owner October 16, 2026 11:08
@chris-ashe
chris-ashe force-pushed the create_plasma_rad_class branch from 816bd7b to 27f73da Compare October 16, 2026 14:25
@timothy-nunn timothy-nunn self-assigned this Oct 21, 2026
@chris-ashe
chris-ashe force-pushed the create_plasma_rad_class branch from 5426feb to 8a985b1 Compare November 3, 2026 11:52

@je-cook je-cook left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions

… plasma radiation fractions from Physics class
@chris-ashe
chris-ashe requested a review from je-cook November 4, 2026 10:06
@je-cook je-cook assigned je-cook and unassigned timothy-nunn Nov 4, 2026

@je-cook je-cook left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres an error in the 5% regression that feels important?

FAILED tests/regression/test_process_input_files.py::test_input_file[spherical_tokamak_eval] - AssertionError:  1 differences: the reference MFile contains different values for some of the variables. See the warnings for a breakdown of the differences.
assert 1 == 0
 +  where 1 = len([MFileVariableDifference(name='pres_plasma_pedestal_thermal', ref=7172.8701719077, new=10520.209585464625, percentage_change=46.66666666666664)])

@je-cook
je-cook merged commit 5e52d67 into main Nov 4, 2026
8 of 11 checks passed
@je-cook

je-cook commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

issue covered in #4727

@je-cook
je-cook deleted the create_plasma_rad_class branch November 4, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Radiation Plasma radiated power Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants