Skip to content

Summary fixes - #4690

Merged
je-cook merged 7 commits into
ukaea:mainfrom
je-cook:summary-fixes
Nov 9, 2026
Merged

je-cook merged 7 commits into
ukaea:mainfrom
je-cook:summary-fixes

Conversation

@je-cook

@je-cook je-cook commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Fixes post summary rework

Also closes #4667

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 13.23529% with 118 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.90%. Comparing base (dcdedfd) to head (563021b).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/plot/summary/plasma/overview.py 2.81% 69 Missing ⚠️
process/core/io/plot/summary/profiles/plasma.py 10.00% 18 Missing ⚠️
process/core/io/plot/summary/common.py 16.66% 15 Missing ⚠️
process/core/io/plot/summary/api.py 0.00% 5 Missing ⚠️
process/core/io/plot/summary/reporting/panels.py 25.00% 3 Missing ⚠️
process/core/io/plot/summary/geometry/misc.py 33.33% 2 Missing ⚠️
process/core/io/plot/summary/magnets/cs.py 60.00% 2 Missing ⚠️
process/core/io/plot/summary/time_profiles.py 50.00% 2 Missing ⚠️
process/core/io/plot/summary/geometry/poloidal.py 50.00% 1 Missing ⚠️
process/data_structure/physics_variables.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4690      +/-   ##
==========================================
+ Coverage   50.26%   50.90%   +0.64%     
==========================================
  Files         181      181              
  Lines       30629    30388     -241     
==========================================
+ Hits        15395    15469      +74     
+ Misses      15234    14919     -315     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@je-cook
je-cook marked this pull request as ready for review October 27, 2026 14:53
@je-cook
je-cook requested a review from a team as a code owner October 27, 2026 14:53

@clmould clmould left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Some text going outside of the box still on the main page:
Image
  • V minor but could all the boxes be the same size here, just as all but 1 are:
Image

@je-cook
je-cook merged commit ac8dbb3 into ukaea:main Nov 9, 2026
8 of 11 checks passed
@je-cook
je-cook deleted the summary-fixes branch November 9, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overlapping text in summary pdf

4 participants