Skip to content

Fix CI and tests #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix CI and tests #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c84f031
Update composer require command in testing.yml
webflo Sep 1, 2025
193b2ce
Run tests on every branch
webflo Sep 1, 2025
a6029c3
Add depreaction for test
webflo Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ name: Testing

on:
push:
branches:
- main
- feature/*

env:
SIMPLETEST_DB: sqlite://localhost/sites/default/files/.ht.sqlite
Expand All @@ -31,7 +28,7 @@ jobs:
composer config prefer-stable true
composer config repositories.0 '{"type": "path", "url": "'$GITHUB_WORKSPACE'/packages/uebertool-companion", "options": {"symlink": false}}'
composer config repositories.1 '{"type": "composer", "url": "https://asset-packagist.org"}'
composer require drupal/core-dev:^11.1.1 \
composer require -W drupal/core-dev:^11.1.1 \
drush/drush \
ueberbit/uebertool_companion

Expand Down
9 changes: 8 additions & 1 deletion ...ges/uebertool-companion/modules/uebertool_twig/src/Twig/Extension/TwigExtrasExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function getFilters(): array {
/**
* {@inheritdoc}
*/
public function getFunctions() {
public function getFunctions(): array {
return [
new TwigFunction('button', [$this, 'getButton']),
new TwigFunction('buttons', [$this, 'getButtons']),
Expand Down Expand Up @@ -218,6 +218,12 @@ public function linkText(?array $build): string {
*/
public function linkAttributes(?array $build): Attribute {
if ($this->isLink($build)) {
$linkAttributes = new Attribute();
$linkAttributes->addClass($build['#url']->getOption('attributes')['class'] ?? []);
if ((string) $linkAttributes) {
@trigger_error('Handling the class attribute from the Url object is deprecated. Use $element["#attributes"] instead. See https://www.drupal.org/node/3494015', E_USER_DEPRECATED);
}

$element = $this->renderer->renderInIsolation($build);
$dom = Html::load($element);
$xpath = new \DOMXPath($dom);
Expand All @@ -228,6 +234,7 @@ public function linkAttributes(?array $build): Attribute {
return $item->nodeValue;
}, iterator_to_array($element->attributes->getIterator())));
$attribute->removeAttribute('href');
$attribute->merge($linkAttributes);
return $attribute;
}

Expand Down
9 changes: 7 additions & 2 deletions ...s/uebertool-companion/modules/uebertool_twig/tests/src/Kernel/TwigExtrasExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,19 +109,24 @@ public function testLinkAttributes(): void {
'class' => 'foo',
],
]));
}

#[IgnoreDeprecations]
public function testLinkAttributesWithUrlOptions(): void {
// Collect attributes from link options.
$url = Url::fromUri('https://example.com');
$url->setOption('attributes', [
'class' => 'foo',
'data-foo' => 'bar',
]);

$this->expectDeprecation('Handling the class attribute from the Url object is deprecated. Use $element["#attributes"] instead. See https://www.drupal.org/node/3494015');
$this->assertEquals(new Attribute([
'data-foo' => 'bar',
'target' => '_blank',
'class' => [
'foo',
],
'data-foo' => 'bar',
'target' => '_blank',
]), $this->twigExtension->linkAttributes([
'#type' => 'link',
'#title' => 'Link text',
Expand Down