fix(workspace): fetch PR refs from real remote, not local origin - #271
Merged
Conversation
xytan0056
force-pushed
the
fix/gitrequest-fetch-remote
branch
3 times, most recently
from
August 6, 2026 01:42
c6da594 to
a1ccd9b
Compare
yushan8
reviewed
Aug 6, 2026
| case "github": | ||
| prNumber, headSHA := parseGitHubPath(u.Path) | ||
| if prNumber == "" { | ||
| return nil, fmt.Errorf("could not extract PR number from path %q", u.Path) |
Contributor
There was a problem hiding this comment.
nit: we should probably classify these as UserError on the orchestrator.
yushan8
reviewed
Aug 6, 2026
| } | ||
| return NewGitRequest(g, pr.Number, baseRef, pr.HeadSHA, logger), nil | ||
| if headSHA == "" { | ||
| return nil, fmt.Errorf("change URI must include a head SHA: %q", rawURL) |
yushan8
approved these changes
Aug 6, 2026
Worker clones created by the repo manager use git clone --local, so their 'origin' remote points to the local origin directory — which has no refs/pull/* refs. gitRequest.Apply() was fetching from 'origin', causing 'couldn't find remote ref pull/NNN/head' errors. Add a remote field to gitRequest and reconstruct the HTTPS URL from the parsed change URI (host/org/repo) so the fetch targets the actual GitHub remote.
xytan0056
force-pushed
the
fix/gitrequest-fetch-remote
branch
from
August 6, 2026 02:02
a1ccd9b to
914788e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git clone --local, so theiroriginremote points to the local origin directory — which has norefs/pull/*refs.gitRequest.Apply()was fetching from"origin", causingcouldn't find remote ref pull/NNN/headerrors.build.Remote) throughNewRequestandNewGitRequestso the fetch targets the actual GitHub remote.github://org/repo/pull/123) and canonical (github://host/org/repo/pull/123/head_sha) URI formats.Test plan
CI
Local test