fix(controller): return Unimplemented from GetChangedTargetGraph stub (audit #5) - #253
Merged
Merged
Conversation
|
|
sbalabanov
commented
Jul 30, 2026
The handler previously returned nil (success with an empty stream), which silently lied to clients and reported success in metrics. Return a YARPC Unimplemented error classified as a user error so clients get an explicit failure, metrics reflect the real outcome (result=user), and the failure counter is emitted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sbalabanov
force-pushed
the
audit/fix-05-unimplemented-changedtargetgraph
branch
from
July 30, 2026 03:33
4173271 to
5fc3a48
Compare
sbalabanov
marked this pull request as ready for review
July 30, 2026 03:34
xytan0056
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetChangedTargetGraphwas a silent stub that returned nil (empty success stream) while the proto contract promises a full streamed changed target graph. Metrics reported success, making it impossible to distinguish the stub from a real call.Unimplementederror classified asErrorUserso clients get an explicit failureresult=user, failure counter emitted witherror_code=userTangoServiceGetChangedTargetGraphYARPCServerTest plan
go build ./...passesgo test ./controller/...passes (new + updated tests)make gazelleBUILD files in sync🤖 Generated with Claude Code