This repository was archived by the owner on Feb 18, 2021. It is now read-only.
Add top level stats path validation #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change validates stats path and warns if any entries do not start with carbon|servers|stats.
|
It'd be nice if you could configure these prefixes, rather than having them hardcoded. Not everybody follows the same schema for stats. |
yashsarma
referenced
this pull request
in lyft/statsrelay
Feb 8, 2017
``` - CLOCK_REALTIME_COARSE - clock_getres: 0 seconds | 4000000 nanoseconds Cost (min): 12 cycles Cost (avg): 53 cycles Cost (max): 37061 cycles - GETTIMEOFDAY - gettimeofday_getres: 1us Cost (min): 309 cycles Cost (avg): 429 cycles Cost (max): 107227 cycles ``` /cc @lyft/observability /cc @theatrus
theatrus
referenced
this pull request
in lyft/statsrelay
Feb 13, 2017
``` - CLOCK_REALTIME_COARSE - clock_getres: 0 seconds | 4000000 nanoseconds Cost (min): 12 cycles Cost (avg): 53 cycles Cost (max): 37061 cycles - GETTIMEOFDAY - gettimeofday_getres: 1us Cost (min): 309 cycles Cost (avg): 429 cycles Cost (max): 107227 cycles ``` /cc @lyft/observability /cc @theatrus
|
|
theatrus
referenced
this pull request
in lyft/statsrelay
May 1, 2020
``` - CLOCK_REALTIME_COARSE - clock_getres: 0 seconds | 4000000 nanoseconds Cost (min): 12 cycles Cost (avg): 53 cycles Cost (max): 37061 cycles - GETTIMEOFDAY - gettimeofday_getres: 1us Cost (min): 309 cycles Cost (avg): 429 cycles Cost (max): 107227 cycles ``` /cc @lyft/observability /cc @theatrus
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change validates stats path and warns if any entries do not
start with carbon|servers|stats.