Add raw data regression tests.#354
Merged
aaronweeden merged 2 commits intoubccr:xdmod11.0from Dec 21, 2023
Merged
Conversation
3 tasks
cdaa69b to
7f9e27a
Compare
89076c4 to
d362f78
Compare
This was referenced Dec 7, 2023
9e9421a to
936864e
Compare
3 tasks
d692ba9 to
e28930a
Compare
e28930a to
7880f4a
Compare
3 tasks
jpwhite4
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds regression tests of the
warehouse/raw-dataREST endpoint for theSUPREMMrealm.This PR is based on #343. The diff between them can be viewed here.
Tests performed
In a Docker container running
tools-ext-01.ccr.xdmod.org/xdmod-job_performance-10.5.0:rockylinux8-0.1with theXDMOD_TEST_MODEenvironment variable set tofresh_install, and then in another Docker container with the same image with it set toupgrade:/unit-{before,after}.txtand make sure the only difference is the amount of time the tests ran./component-{before,after}.txtand make sure the only difference is the amount of time the tests ran./regression-{before,after}.txtand confirm two new tests were run forWarehouseRawDataSupremmTest::testGetRawData, and make sure otherwise the only differences are randomized parameters, amount of time the tests ran, and possibly transient "other notices" related to small differences in column values./integration-{before,after}.txtand make sure the only difference is the amount of time the tests ran.REG_TEST_ALL=1 /xdmod-supremm/tests/regression/runtests.shI also made sure CircleCI uploads the new test results file
/root/phpunit/xdmod-supremm-regression-warehouse.xml.Types of changes
Checklist: