Warn instead of throwing exception if raw data stream is closed unexpectedly.#89
Open
aaronweeden wants to merge 3 commits intoubccr:v1.x.yfrom
Open
Warn instead of throwing exception if raw data stream is closed unexpectedly.#89aaronweeden wants to merge 3 commits intoubccr:v1.x.yfrom
aaronweeden wants to merge 3 commits intoubccr:v1.x.yfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When calling
get_raw_data(), if the stream is closed before all rows are sent, aRuntimeErroris raised, and the partial results are thrown away. This PR changes the behavior to instead log a warning so that partial results can be kept without needing to fetch all the data again.This PR also adds code to catch
requests.exceptions.ChunkedEncodingErrorwhich is another error that can occur when a connection is closed early.Tests performed
With the changes from this PR installed, I tested running the following and confirming it causes the warning:
and changed the end date to
2025-01-01and confirmed it didn't cause the warning.Type of change:
Checklist:
xdmod-notebooksrepository as necessary, and the notebooks all run successfully