Closed
Conversation
Author
|
Closed in favor of #19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This improves the performance of raw data requests.
Instead of repeatedly requesting the entire time range in chunks of 10,000 rows (or whatever the portal has configured as the
rest_raw_row_limit), the method now makes a separate request for each day in the range, still in chunks of 10,000 rows (or whateverrest_raw_row_limitis).For example, instead of:
it is now (note that for each request,
start_date == end_date):The full result is received faster, even though more queries are made (e.g., ~1min for 7 days (258,836 rows) of SUPREMM data as opposed to ~1m20s seconds), and for a portal that implements ubccr/xdmod#1780, requests for raw Jobs realm data are received much faster (around 20 seconds to fetch two days (63,251 rows) of Jobs data as opposed to around 25 minutes).
This also updates the
show_progressfeature to also print the number of days that have been retrieved so far.TODO: add tests
Motivation and Context
Requests for raw data in the ACCESS XDMoD Jobs realm are incredibly slow. This is also the case for
metrics-staging.Tests performed
Types of changes
Checklist:
docs/developing.md) produces no errors.