Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the robustness of specifying the Typst executable file name by implementing a standardized naming scheme and handling multiple executable names for the same version.
- Introduces logic to preserve a standard
typst-${version}executable alongside custom executable names - Adds caching logic to check for existing executables before re-copying them
- Updates code formatting (trailing commas) and documentation formatting throughout the codebase
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/main.ts | Implements the core logic for managing multiple executable names, including creating a versioned copy and renaming executables. Also includes extensive formatting changes (trailing commas). |
| README.md | Documents the new executable-name behavior, clarifying that a typst-${version} executable is always preserved and adds guidance on using multiple executable names. Also includes formatting improvements. |
| README_zh-Hans-CN.md | Chinese translation of the README documentation updates, including the same guidance on executable naming and formatting improvements. |
| .github/workflows/test.yml | Updates YAML formatting to use consistent double quotes and bracket styles for better code consistency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #51