-
-
Couldn't load subscription status.
- Fork 1.2k
Add doctest example for Op in cats core #4782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the PR! The CI failed due to a formatting issue, try running |
|
I think it would be nice if it would be possible to explain in the docs why someone may want/need this The class was introduced in #2217 (Add dual categories). As far as I concerned, the "Dual Category" term comes from "Category Theory" and in a nutshell refers to an ability to flip the direction of an arrow. But it doesn't explain why someone may need this class specifically, because its |
I’ve addressed both feedback, ran scalafmtAll to fix the formatting issues, and added documentation explaining the purpose and usage of the Op class. |
I’ve addressed both feedback, ran scalafmtAll to fix the formatting issues, and added documentation explaining the purpose and usage of the Op class. |
restored correct package structure (package cats; package data), simplified class-level Scaladoc for better clarity, replaced previous example with a more illustrative dual composition example
|
Hi @satorg, I just saw that the CI flagged a missing header for |
|
hello @satorg, I have made corrections as per the headercheck. Please kindly check and let me know the next step when you can. Thanks! |
|
Hi @satorg, can you please recheck and let me know...Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
You’re welcome! |
This pull request adds a doctest for the Op type in cats.core.
The doctest provides a simple usage example demonstrating how Op can be used for contravariant composition.