-
Notifications
You must be signed in to change notification settings - Fork 54
Use custom python toolchain for cloudsmith uploader #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
krishnangovindraj
wants to merge
7
commits into
typedb:master
from
krishnangovindraj:add-interpreter-path-to-uploader-pip
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e5de134
Add python interpreter argument to uploader deps
krishnangovindraj b051172
Typedb for name and requiremetns lock
krishnangovindraj c9a9200
Experiment with toolchains for uploader
krishnangovindraj e5afb1d
Do we not need the toolchain declaration?
krishnangovindraj fea297a
We don't need the toolchain declaration
krishnangovindraj 94a7b1c
Add print for debugging
krishnangovindraj 61e321e
how about now?
krishnangovindraj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,14 @@ | ||
| load("@rules_python//python:repositories.bzl", "py_repositories", "python_register_toolchains") | ||
| load("@rules_python//python:pip.bzl", "pip_parse") | ||
| load("//common:rules.bzl", "python_interpreter_symlink") | ||
|
|
||
|
|
||
| def typedb_bazel_distribution_uploader(): | ||
| uploader_toolchain_name = "py39_for_uploader" | ||
| python_register_toolchains(name=uploader_toolchain_name, python_version="3.9", ignore_root_user_error = True) | ||
| python_interpreter_symlink(name="py39_for_uploader_symlink", interpreter_toolchain_name = uploader_toolchain_name) | ||
| pip_parse( | ||
| name = "typedb_bazel_distribution_uploader", | ||
| requirements_lock = "@typedb_bazel_distribution//common/uploader:requirements.txt", | ||
| python_interpreter_target = "@py39_for_uploader_symlink//:python" | ||
| ) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relies on
rules_pythonto have3.9.We could try a newer one too.