Skip to content

Improve logging to list unconverted ancestors of given commit SHA #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjornbjornsson wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve logging to list unconverted ancestors of given commit SHA #857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b3bde9
Improve logging to list unconverted ancestors of given commit SHA
bjornbjornsson Feb 28, 2022
46f2582
Address suggestions
bjornbjornsson Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions node/lib/util/stitch_util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,6 +873,18 @@ exports.listCommitsToStitch = co.wrap(function *(repo,
}
const commitShas = exports.listCommitsInOrder(commit.id().tostrS(),
allParents);
const shortCommitShas = [];
for (const commitSha of commitShas) {
shortCommitShas.push(commitSha.slice(0,7));
}
shortCommitShasMessage = shortCommitShas.join(", ");
if (shortCommitShasMessage.length > 1000) {
shortCommitShasMessage = shortCommitShasMessage.slice(0,1000);
shortCommitShasMessage.concat(`[Message too long and was ` +
`truncated to 1000 characters]`);
}
console.log(`listing all ${commitShas.length} unconverted ancestors of ` +
`${commit.id.tostrS()}: ${shortCommitShasMessage}`);
return commitShas.map(sha => commitMap[sha]);
});

Expand Down