Skip to content

Support extended ternary operator for undefined argument. #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support extended ternary operator for undefined argument. #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/twig.expression.operator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ module.exports = function (Twig) {

break;
case '?':
if (a === undefined) {
if (a === undefined && b !== undefined) {
// An extended ternary.
a = b;
b = c;
Expand Down
13 changes: 13 additions & 0 deletions test/test.expressions.operators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,19 @@ describe('Twig.js Expression Operators ->', function () {
outputT.should.equal('one');
outputF.should.equal('two');
});

it('should support the extended ternary operator for undefined arguments', function () {
const testTemplate = twig({data: '{{ test1 ? test1 : test2 }}'});
const outputA = testTemplate.render({test2: 'text 2'});
const outputB = testTemplate.render({test1: false});
const outputC = testTemplate.render({});
const outputD = testTemplate.render({test1: 'text 1'});

outputA.should.equal('text 2');
outputB.should.equal('');
outputC.should.equal('');
outputD.should.equal('text 1');
});
});

describe('?? ->', function () {
Expand Down