Skip to content

cabal: Add support for empty libraries #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

cabal: Add support for empty libraries #2287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48c1aa2
cabal: Always process package config files
iteratee May 15, 2025
b2adf27
cabal: Add provider and rule for cabal settings
iteratee May 15, 2025
b4b5419
cabal: add empty_lib to stack snapshot components
iteratee May 15, 2025
bfef6e9
cabal: Add ignore_setup flag to cabal_args
iteratee May 17, 2025
5ff9fd9
cabal: Wire components_args into the module version of stack_snapshot
iteratee Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions extensions/stack_snapshot.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,17 @@ _package_tag = tag_class(
default = False,
doc = "Configuring a package makes it visible by default, unless `hidden` is set to True",
),
"components_args": attr.string_dict(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a TODO that we want to use attr.string_keyed_label_dict(providers = [HaskellCabalLibraryArgs]) here in later bazel versions?

doc = """ components_args: Defines map from component to cabal settings for that package.
The cabal settings are a target of type `haskell_cabal_args`. Currently handles empty
libraries and telling the build system to ignore `Setup.hs`.
Use `lib` for the main library component, `exe:<exe-name>` for an executable component,
and `lib:<sublib-name>` for a sublibrary.
`exe` is a short-cut for `exe:<package-name>`.
Either use the builtin "@rules_haskell//tools/cabal_args:empty_library", or create your own
if necessary.
""",
),
},
)

Expand Down Expand Up @@ -180,6 +191,8 @@ def _add_packages(conf, module, root_or_rules_haskell):
if package_tag.components != ["DETECT_DEFAULT"]:
# Some packages have default components set
conf.components[package_name] = package_tag.components
if package_tag.components_args:
conf.components[package_name] = package_tag.components_args
if package_tag.components_dependencies:
conf.components_dependencies[package_name] = json.encode(package_tag.components_dependencies)
if package_tag.extra_deps:
Expand Down Expand Up @@ -295,6 +308,7 @@ def _stack_snapshot_impl(mctx):
extra_deps = {},
components = {},
components_dependencies = {},
components_args = {},
vendored_packages = {},
)

Expand All @@ -318,6 +332,7 @@ def _stack_snapshot_impl(mctx):
kwargs["flags"] = packages_conf.flags
kwargs["components"] = packages_conf.components
kwargs["components_dependencies"] = packages_conf.components_dependencies
kwargs["components_args"] = packages_conf.components_args
kwargs["extra_deps"] = packages_conf.extra_deps
kwargs["vendored_packages"] = packages_conf.vendored_packages
kwargs["name"] = "stackage"
Expand Down
Loading
Loading