Fix(collapse): prevent race condition on rapid accordion clicks - #42844
Open
MohamedAlfeky1 wants to merge 1 commit into
Open
Fix(collapse): prevent race condition on rapid accordion clicks#42844MohamedAlfeky1 wants to merge 1 commit into
MohamedAlfeky1 wants to merge 1 commit into
Conversation
Fix an issue where rapidly clicking different accordion toggle buttons can cause multiple accordion items to remain open simultaneously. When multiple active children exist within an accordion parent (such as one resting and another transitioning), checking only activeChildren[0]._isTransitioning failed if the transitioning element appeared later in DOM order. Tracking expanding state and inspecting all active children prevents subsequent show() invocations while transitions are in flight. Fixes twbs#41883
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race condition in the
Collapseplugin when used as an accordion. Rapidly clicking different accordion items in quick succession previously allowed multiple items to remain open simultaneously.Motivation & Context
When multiple active children exist within an accordion parent (such as one resting and another transitioning), checking only
activeChildren[0]._isTransitioningfailed if the transitioning element appeared later in DOM order. Additionally,SELECTOR_ACTIVESwas previously requiring.collapse.collapsing, which did not match in-flight elements during transition since.collapseis removed.Fixes:
SELECTOR_ACTIVESto'.collapse.show, .collapsing'._isExpandingstate to guardshow()against in-flight sibling expansions.js/tests/unit/collapse.spec.js.Type of changes
Checklist
npm run lint)Related issues
Closes #41883