feat: honour --targets app on macOS for app-only builds#1248
Open
kud wants to merge 1 commit into
Open
Conversation
d8208f5 to
13b8575
Compare
13b8575 to
1255b80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On macOS,
pake <url> --targets appalways produced a.dmginstead of an app-only build. This makes--targets appactually build only the.appbundle, skipping the DMG packaging step.Why
merge.tsalready treatsappas a valid macOS bundle target (validMacTargets = ['app', 'dmg']), butMacBuilder's constructor setbuildFormattodmgfor any value that wasn't an arch — and then overwroteoptions.targetswith it beforemergeConfigcould apply theapptarget. So theappbranch inmerge.tswas unreachable.Building the DMG also mounts a volume window and adds noticeable time, which is unnecessary when you only want the
.app.How
Treat an explicit
--targets appthe same way--installanditerativeBuildalready request theappformat in the constructor.Tests
Adds
tests/unit/mac-builder-targets.test.ts:--targets appyields an app-only filename;dmg/default/arch values still resolve to DMG builds. Full suite: 174 passing.Docs
Documents
app/dmgas macOS output formats indocs/cli-usage.mdanddocs/cli-usage_CN.md.