Fix 'placement' prop being named 'position' in README#155
Open
mlmmn wants to merge 1 commit intotvkhoa:masterfrom
mlmmn:fix-readme-tippy-placement-prop
Open
Fix 'placement' prop being named 'position' in README#155mlmmn wants to merge 1 commit intotvkhoa:masterfrom mlmmn:fix-readme-tippy-placement-prop
mlmmn wants to merge 1 commit intotvkhoa:masterfrom
mlmmn:fix-readme-tippy-placement-prop
Conversation
|
I would like to point out that this really needs to be accepted as a merge.... its been two years and still the wrong prop is used in the documentation. Without this change someone using the component needs to go into the actual code to figure out why the "position" prop wont work the way it is intended to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.