feat(dApp): Added Git identity binding during member registration. by theobiabo · Pull Request #224 · tupui/soroban-versioning

theobiabo · 2025-07-14T16:41:19Z

Adds SEP-53 compliant Git identity linking during registration. Supports GitHub/GitLab with Ed25519 signature verification.

Optional provider:username input
Auto-fetch public keys from Git providers
SEP-53 envelope with network validation
Signature verification using @noble/ed25519
Step-by-step UI flow with skip option

This PR fixed the issue on #217

netlify · 2025-07-14T16:41:24Z

✅ Deploy Preview for staging-tansu ready!

Name	Link
🔨 Latest commit	`7cce6c1`
🔍 Latest deploy log	https://app.netlify.com/projects/staging-tansu/deploys/68eb27be777b1900086dfa93
😎 Deploy Preview	https://deploy-preview-224--staging-tansu.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 69 Accessibility: 89 Best Practices: 83 SEO: 92 PWA: 80 View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-07-14T16:42:39Z

✅ Deploy Preview for tansu canceled.

Name	Link
🔨 Latest commit	`0d0ca64`
🔍 Latest deploy log	https://app.netlify.com/projects/tansu/deploys/687533329b64c00008b0d26b

tupui

Good start thanks! A few comments.

tupui · 2025-07-20T00:35:03Z

Actually, I am not sure we need all that to be in the contract itself vs the meta file-if even needed. I would keep the handle and key only. And in meta nothing. What do you think?

Sorry i don't get you clearly

you mean i should remove this git_identity?: string; git_pubkey?: Buffer; msg?: string; sig?: Buffer; signed_at?: u64;

?

Yes we just need the identity and key to be stored in the contract. When I will call the smart contract function add_member I will pass everything though as to validate on-chain the data.

tupui · 2025-09-30T11:01:03Z

@yhoungdev are you still working on this?

theobiabo · 2025-09-30T11:14:39Z

Yes i am @tupui

theobiabo · 2025-09-30T11:14:52Z

would resolve the conflict in a little while

netlify · 2025-10-03T06:38:43Z

✅ Deploy Preview for tansu canceled.

Name	Link
🔨 Latest commit	`7cce6c1`
🔍 Latest deploy log	https://app.netlify.com/projects/tansu/deploys/68eb27be8967570008f6c440

tupui · 2025-10-03T09:56:41Z

Is this ready for another review? Or you still need to update to integrate what I had said here and in our chat?

tupui · 2025-10-03T17:10:42Z

@yhoungdev let me know.

theobiabo · 2025-10-03T20:25:51Z

It is still a wip in my branch.

…into feature/git_identity_binding

theobiabo · 2025-10-05T16:43:20Z

@yhoungdev are you still working on this?

You can check again

tupui · 2025-10-05T17:15:42Z

@yhoungdev please test first yourself the deployment https://deploy-preview-224--staging-tansu.netlify.app/

theobiabo · 2025-10-05T17:21:36Z

Ok

theobiabo · 2025-10-05T19:56:36Z

@tupui from your test how was it so far?

tupui · 2025-10-05T20:18:12Z

I asked you above to check the deployment because the deployment is not working.

JoinCommunityModal.TaDYHw7a.js:2 Uncaught ReferenceError: GitVerification is not defined
    at ye (JoinCommunityModal.TaDYHw7a.js:2:6319)
    at jf (client.CH8PIGmd.js:32:47866)
    at nc (client.CH8PIGmd.js:32:70573)
    at qy (client.CH8PIGmd.js:32:80897)
    at fv (client.CH8PIGmd.js:32:116458)
    at xm (client.CH8PIGmd.js:32:115538)
    at _c (client.CH8PIGmd.js:32:115375)
    at lv (client.CH8PIGmd.js:32:112211)
    at Tv (client.CH8PIGmd.js:32:123862)
    at MessagePort.Ba (client.CH8PIGmd.js:9:1643)

theobiabo · 2025-10-05T20:45:43Z

ok, but the Irony here is that Netlify is building fine 😅

theobiabo · 2025-10-05T20:45:58Z

I asked you above to check the deployment because the deployment is not working.

JoinCommunityModal.TaDYHw7a.js:2 Uncaught ReferenceError: GitVerification is not defined
    at ye (JoinCommunityModal.TaDYHw7a.js:2:6319)
    at jf (client.CH8PIGmd.js:32:47866)
    at nc (client.CH8PIGmd.js:32:70573)
    at qy (client.CH8PIGmd.js:32:80897)
    at fv (client.CH8PIGmd.js:32:116458)
    at xm (client.CH8PIGmd.js:32:115538)
    at _c (client.CH8PIGmd.js:32:115375)
    at lv (client.CH8PIGmd.js:32:112211)
    at Tv (client.CH8PIGmd.js:32:123862)
    at MessagePort.Ba (client.CH8PIGmd.js:9:1643)

Ok, i will fix this.

tupui · 2025-10-09T15:57:06Z

Any updates? Just so you know. OnlyDust is soon ending all their programs. If you don't finish very soon, I won't be able to give you anything with their platform.

theobiabo · 2025-10-09T16:15:34Z

Yess i have an update.

theobiabo · 2025-10-09T23:22:33Z

Conflict has been resolved.

theobiabo · 2025-10-09T23:28:44Z

I asked you above to check the deployment because the deployment is not working.

JoinCommunityModal.TaDYHw7a.js:2 Uncaught ReferenceError: GitVerification is not defined
    at ye (JoinCommunityModal.TaDYHw7a.js:2:6319)
    at jf (client.CH8PIGmd.js:32:47866)
    at nc (client.CH8PIGmd.js:32:70573)
    at qy (client.CH8PIGmd.js:32:80897)
    at fv (client.CH8PIGmd.js:32:116458)
    at xm (client.CH8PIGmd.js:32:115538)
    at _c (client.CH8PIGmd.js:32:115375)
    at lv (client.CH8PIGmd.js:32:112211)
    at Tv (client.CH8PIGmd.js:32:123862)
    at MessagePort.Ba (client.CH8PIGmd.js:9:1643)

Ok, i will fix this.

This has been fixed, please check and confirm.

theobiabo · 2025-10-09T23:28:58Z

Let me know if there are any other issues/errors.

theobiabo · 2025-10-10T02:23:47Z

Can i see error logs? if there is any.

tupui · 2025-10-10T03:26:54Z

You can see the logs on Netlify yes. Just look at the links for the CI.

Otherwise did you test it with the deployment now? Can you share screenshots of the tests?

theobiabo · 2025-10-10T04:09:02Z

https://deploy-preview-224--staging-tansu.netlify.app/

After "link Git handle" button has been clicked

theobiabo · 2025-10-12T04:08:23Z

I just pushed a fix for it @tupui

for the now i am using an external proxy server with the Github endpoint

So technically it will be like this
https://corsproxy.io/?${encodeURIComponent(originalUrl)}

Now you can now make requests to fetch pkeys safely, let me know if there are any issues.

tupui · 2025-10-16T15:10:31Z

@yhoungdev I am trying to test but got some issues

Also for the command to type, this is not portable. I think we don't need the /dev/stdin since it's a pipe and use the last command's output as an input.

theobiabo · 2025-10-16T15:12:02Z

Ok, no problem, i will look into that fix @tupui

tupui · 2025-11-30T18:01:37Z

@yhoungdev are you still interested in finishing this one?

theobiabo · 2025-11-30T18:10:03Z

Yes Roy, i would attend to the error in some hours.

theobiabo · 2025-11-30T18:34:18Z

Looking into the conflict.

netlify · 2026-01-19T11:32:09Z

👷 Deploy request for tansu pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`09f5409`

netlify · 2026-01-19T11:32:11Z

✅ Deploy Preview for staging-tansu ready!

Name	Link
🔨 Latest commit	`09f5409`
🔍 Latest deploy log	https://app.netlify.com/projects/staging-tansu/deploys/6970fcb4e1e51300089e87f1
😎 Deploy Preview	https://deploy-preview-224--staging-tansu.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 56 Accessibility: 85 Best Practices: 83 SEO: 92 PWA: 70 View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

theobiabo · 2026-01-19T11:57:20Z

Hello @tupui please can you check it out now?

theobiabo · 2026-01-19T12:25:53Z

PROOF OF WORK FROM LIVE URL

1).

2).

3). Testing envelop signature.
I noticed undefined is being appended to the key

NB: I am currently checking the issue.

theobiabo · 2026-01-19T19:04:29Z

Update

Bug: Fixed SEP-53 Envelope to sign token showing undefined (due to its no seeing Contract ID)

Stellar Signed Message
Test SDF Network ; September 2015
GBCHKZFGQKLO3FFOKYQXUNWYZUAINFI7IDJVG7343Y3O6RWVKSXNGHFI
32866da2e12e386ec91cf9f5ee7c06a3
tansu-bind|undefined|github:yhoungdev

Fixed (Current)

Stellar Signed Message
Test SDF Network ; September 2015
GBCHKZFGQKLO3FFOKYQXUNWYZUAINFI7IDJVG7343Y3O6RWVKSXNGHFI
32866da2e12e386ec91cf9f5ee7c06a3
tansu-bind|CDEF4XBUFRFXAXX2BVEWJYXVJSOE2S5FZTUYY7II2RNUELFFE4CLUFFJ|github:yhoungdev

Signing Envelope with Git key

tupui · 2026-03-02T12:07:48Z

Alright, I will have to say last ping 😅 This has been delayed for way too long now and I am losing my hairs with all the new PRs trying to do this over and over again. At that point I should just yolo it myself. So I will give you 2 weeks if you want to finish. You have other PRs to also look at with tons of comments etc. I will only consider reviewing if it fully works and after seeing some videos of it. Yep that means you need to deploy your own contract locally and test locally end to end. Otherwise that's not helping me at all to be honest if I have to do all that myself. Hopefully you understand my position.

theobiabo · 2026-03-02T12:09:19Z

Yes i do @tupui

feat (Git): Added Git identity binding during member registration.

0d0ca64

tupui reviewed Jul 20, 2025

View reviewed changes

tupui linked an issue Sep 25, 2025 that may be closed by this pull request

Add Git identity binding during member registration #217

Open

fixed merge conflict

feb9653

theobiabo added 2 commits October 5, 2025 15:31

Merge branch 'main' of https://github.com/yhoungdev/soroban-versioning …

e4e92de

…into feature/git_identity_binding

chore: updated suggestions

525d223

fixing conflict

d892caa

fixed undefined Gitverevification function error

62e5f3b

bug: fixed Github binding CORs issues

7cce6c1

fixing local conflict

f3c8957

bug: fixed merge conflict

424e165

chore(cmd): removed /dev/stdin.

f6ad36c

theobiabo added 4 commits January 19, 2026 21:21

enhance(Signature): optimized signature handling flow

d83d280

bug: fixing parseSSHSignature

dc3a031

chore: added copybutton and hide pgp if option is ssh

979263d

chore: added sshsig for handling ssh verification

09f5409

tupui mentioned this pull request Jan 24, 2026

Implement Git Identity Binding with SEP-53 Verification #392

Closed

Conversation

theobiabo commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for staging-tansu ready!

Uh oh!

netlify Bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for tansu canceled.

Uh oh!

tupui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tupui Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

theobiabo Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

tupui Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

tupui commented Sep 30, 2025

Uh oh!

theobiabo commented Sep 30, 2025

Uh oh!

theobiabo commented Sep 30, 2025

Uh oh!

netlify Bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for tansu canceled.

Uh oh!

tupui commented Oct 3, 2025

Uh oh!

tupui commented Oct 3, 2025

Uh oh!

theobiabo commented Oct 3, 2025

Uh oh!

theobiabo commented Oct 5, 2025

Uh oh!

tupui commented Oct 5, 2025

Uh oh!

theobiabo commented Oct 5, 2025

Uh oh!

theobiabo commented Oct 5, 2025

Uh oh!

tupui commented Oct 5, 2025

Uh oh!

theobiabo commented Oct 5, 2025

Uh oh!

theobiabo commented Oct 5, 2025

Uh oh!

tupui commented Oct 9, 2025

Uh oh!

theobiabo commented Oct 9, 2025

Uh oh!

theobiabo commented Oct 9, 2025

Uh oh!

theobiabo commented Oct 9, 2025

Uh oh!

theobiabo commented Oct 9, 2025

Uh oh!

theobiabo commented Oct 10, 2025

Uh oh!

tupui commented Oct 10, 2025

Uh oh!

theobiabo commented Oct 10, 2025

Uh oh!

theobiabo commented Oct 12, 2025

Uh oh!

tupui commented Oct 16, 2025

Uh oh!

theobiabo commented Oct 16, 2025

Uh oh!

tupui commented Nov 30, 2025

Uh oh!

theobiabo commented Nov 30, 2025

theobiabo commented Jul 14, 2025 •

edited

Loading

netlify Bot commented Jul 14, 2025 •

edited

Loading

netlify Bot commented Jul 14, 2025 •

edited

Loading

netlify Bot commented Oct 3, 2025 •

edited

Loading

netlify Bot commented Jan 19, 2026 •

edited

Loading

netlify Bot commented Jan 19, 2026 •

edited

Loading

theobiabo commented Jan 19, 2026 •

edited

Loading