Skip to content

FLYPIE-269 Handle files that are not empty, but have 0 records #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkinzer merged 1 commit into from
Aug 21, 2026
Merged

FLYPIE-269 Handle files that are not empty, but have 0 records #1815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions funcake_dags/scripts/transform.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ OBJECTS=$(

SKIPPED_EMPTY_FILES=0
PROCESSED_FILES=0
ZERO_RECORD_OUTPUT_FILES=0

while IFS=$'\t' read -r SOURCE_XML SOURCE_SIZE
do
Expand Down Expand Up @@ -85,6 +86,10 @@ do
java -jar $SAXON_CP -xsl:$SCRIPTS_PATH/batch-transform.xsl -s:$SOURCE_XML-2.xml -o:$SOURCE_XML-transformed.xml -t
COUNT=$(grep -o "<oai_dc:dc" "$SOURCE_XML-transformed.xml" | wc -l || :)
TOTAL_TRANSFORMED=$((TOTAL_TRANSFORMED + COUNT))
if [ "$COUNT" -eq 0 ]; then
echo "No transformed records found in output for: $SOURCE_XML"
ZERO_RECORD_OUTPUT_FILES=$((ZERO_RECORD_OUTPUT_FILES + 1))
fi
aws s3 cp $SOURCE_XML-transformed.xml s3://$BUCKET/$TRANSFORM_XML

TEMPFILE=$(mktemp /tmp/identifier-output-$DAG_ID.XXXXXX)
Expand Down Expand Up @@ -113,3 +118,4 @@ echo "Total Records transformed: $TOTAL_TRANSFORMED"
echo "Unique Record Count: $UNIQUE_RECORD_COUNT"
echo "Files transformed: $PROCESSED_FILES"
echo "Empty files skipped: $SKIPPED_EMPTY_FILES"
echo "Files with 0 transformed records: $ZERO_RECORD_OUTPUT_FILES"
4 changes: 4 additions & 0 deletions tests/transform_script_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def test_skips_zero_byte_s3_objects(self):
self.assertIn("Skipping empty source file", result.stdout)
self.assertIn("Files transformed: 0", result.stdout)
self.assertIn("Empty files skipped: 1", result.stdout)
self.assertIn("Files with 0 transformed records: 0", result.stdout)
self.assertEqual(uploads, "")
self.assertEqual(transformed_files, [])

Expand Down Expand Up @@ -56,6 +57,7 @@ def test_processes_non_empty_objects_and_skips_empty_ones(self):
self.assertEqual(result.returncode, 0, msg=result.stderr)
self.assertIn("Files transformed: 2", result.stdout)
self.assertIn("Empty files skipped: 1", result.stdout)
self.assertIn("Files with 0 transformed records: 0", result.stdout)
self.assertEqual(
uploads.strip().splitlines(),
[
Expand All @@ -77,6 +79,8 @@ def test_handles_transformed_files_with_zero_records(self):
self.assertIn("Total Records transformed: 0", result.stdout)
self.assertIn("Files transformed: 1", result.stdout)
self.assertIn("Empty files skipped: 0", result.stdout)
self.assertIn("No transformed records found in output for:", result.stdout)
self.assertIn("Files with 0 transformed records: 1", result.stdout)
self.assertEqual(
uploads.strip().splitlines(),
["s3://test-bucket/funcake_test/2021-03-23_17-25-10/transformed/file1.xml"],
Expand Down