fix(oUF_AuraWatch): coerce all secret-value aura fields to prevent 'script ran too long' in Midnight 12.0 - #1868
Closed
mjodheim wants to merge 1 commit into
Closed
Conversation
…cript ran too long' In Midnight 12.0, secret auras return secret values for several fields (applications, castByPlayer, spellID, sourceUnit). The existing fix only handled count and castByPlayer, but spellID and source were still stored raw on button frames, causing taint propagation into the FilterIcons loop. When tainted values enter the loop's control flow, Blizzard loses execution budget tracking, causing 'script ran too long' errors. Coerce all four potentially-secret fields to safe defaults immediately after UnpackAuraData: - count (applications) -> 0 if secret - castByPlayer -> nil if secret - spellID -> 0 if secret (prevents tainted table lookups in element.watched) - source -> nil if secret (simplifies button.isPlayer to direct comparison)
Member
|
this is irrelevant in 12.1 - closing the issue. thanks tho 🌼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Midnight 12.0, secret auras return secret values for several fields (applications, castByPlayer, spellID, sourceUnit). The existing fix only handled
countandcastByPlayer, butspellIDandsourcewere still stored raw on button frames, causing taint propagation into the FilterIcons loop.When tainted values enter the loop's control flow, Blizzard loses execution budget tracking, causing 'script ran too long' errors.
Changes:
spellID→0if secret (prevents tainted table lookups inelement.watched)source→nilif secret (simplifiesbutton.isPlayerto direct comparison)count→0andcastByPlayer→nilfor completeness (already present in some forks)oUF:NotSecretValue(source)wrapper since source is already nil-safeTesting: Used in retail Midnight (TOC 120007), all four coercions verified necessary to prevent the error.