fix tooltip widget set taint#1837
Draft
mjodheim wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Wrap Retail
GameTooltip_AddWidgetSetso ElvUI calls Blizzards original implementation throughsecurecallfunction.Why
Some tooltip widget sets can expose secret values while Blizzard lays out UI widgets. When
GameTooltip_AddWidgetSetruns in an ElvUI-tainted execution path, Blizzard code can crash while doing arithmetic on those secret values, for example:Calling the original Blizzard function through
securecallfunctionavoids carrying ElvUI taint into the widget processing path, without suppressing any widget set or hiding tooltip content.Reproduction observed
1273GameTooltip_AddWidgetSet->UIWidgetManager:RegisterForWidgetSet->TextWithStateWidget:SetupValidation
git diff --check/reloadplus the affected Area POI hover path