Skip to content

replication factor shoudl be 3 by default #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsuz wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

replication factor shoudl be 3 by default #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion processor-apps/processing/src/main/java/io/flightdeck/streams/FlightDeckStreamsApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ private static void ensureTopicsExist(Properties streamsProps) {
KafkaEnvProps.apply(adminProps);
adminProps.put(AdminClientConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServers);

int partitions = Integer.parseInt(
System.getenv().getOrDefault("KAFKA_TOPIC_PARTITIONS", "1"));
short replicationFactor = Short.parseShort(
System.getenv().getOrDefault("KAFKA_TOPIC_REPLICATION_FACTOR", "3"));
Comment on lines +153 to +155

List<String> requiredTopics = new java.util.ArrayList<>(List.of(
Topics.MESSAGE_INPUT,
Topics.ENRICHED_MESSAGE_INPUT,
Expand All @@ -174,7 +179,7 @@ private static void ensureTopicsExist(Properties streamsProps) {

List<NewTopic> toCreate = requiredTopics.stream()
.filter(t -> !existing.contains(t))
.map(t -> new NewTopic(t, 1, (short) 1))
.map(t -> new NewTopic(t, partitions, replicationFactor))
.collect(Collectors.toList());

if (!toCreate.isEmpty()) {
Expand Down
Loading