Skip to content

Improve Fungal Cavern sublocation logic#341

Merged
AardWolf merged 1 commit intotsitu:masterfrom
zozoens31:bm-cre/fungal-standard-cheese
Mar 1, 2026
Merged

Improve Fungal Cavern sublocation logic#341
AardWolf merged 1 commit intotsitu:masterfrom
zozoens31:bm-cre/fungal-standard-cheese

Conversation

@zozoens31
Copy link
Contributor

Summary

  • Improve sublocation detection logic for Fungal Cavern in the CRE bookmarklet
  • Adds standard cheese handling for Fungal Cavern sublocations

Test plan

  • Verify CRE bookmarklet correctly detects Fungal Cavern sublocations with standard cheese

🤖 Generated with Claude Code

@hymccord
Copy link
Contributor

Two things:

  1. I agree the sublocation logic needs to be changed since using standard cheese should not be a sublocation but you don't need to return "-". Just don't return anything. "-" is the default when the urlparam for sublocation isn't specified.
  2. You also need to update the logic in a 2nd place; src/bookmarklet/bm-setup-fields.js

Basically the logic for it to be either Gemology or Not Gemology requires the user to have cavern based cheese.

Pseudo code:

if (hasCavernCheese) {
  return hasGemologyBase ? "Gemology" : "Not Gemology"
}

- Add specific cheese check for non-Gemology base cases
- Return 'Not Gemology' for Glowing Gruyere, Mineral, Gemstone, or Diamond cheese
- Return '-' for other cheese types when not using Gemology Base
- Simplify code by removing unnecessary else statements with early returns
@zozoens31 zozoens31 force-pushed the bm-cre/fungal-standard-cheese branch from e35b1a7 to 4f832fe Compare February 27, 2026 12:15
Copy link
Contributor

@hymccord hymccord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll ping Aard since he's got merge powah.

@AardWolf AardWolf merged commit 8b19ca0 into tsitu:master Mar 1, 2026
2 checks passed
@zozoens31 zozoens31 deleted the bm-cre/fungal-standard-cheese branch March 2, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants