Improve Fungal Cavern sublocation logic#341
Merged
AardWolf merged 1 commit intotsitu:masterfrom Mar 1, 2026
Merged
Conversation
Contributor
|
Two things:
Basically the logic for it to be either Gemology or Not Gemology requires the user to have cavern based cheese. Pseudo code: |
- Add specific cheese check for non-Gemology base cases - Return 'Not Gemology' for Glowing Gruyere, Mineral, Gemstone, or Diamond cheese - Return '-' for other cheese types when not using Gemology Base - Simplify code by removing unnecessary else statements with early returns
e35b1a7 to
4f832fe
Compare
hymccord
approved these changes
Feb 28, 2026
Contributor
hymccord
left a comment
There was a problem hiding this comment.
LGTM. I'll ping Aard since he's got merge powah.
AardWolf
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code