Replace symphonia with rockbox playback - #4
Merged
Conversation
The local audio renderer previously hand-rolled a symphonia + cpal + rb stack (queue, shuffle/repeat, resume, ReplayGain, crossfade, EQ/tone DSP, HTTP streaming) in a 2215-line SymphoniaPlayer. rockbox-playback 0.4 now provides all of that natively, so swap the implementation for a thin adapter over its Player. - Add rockbox-playback = "0.4"; drop symphonia, cpal, rb and the direct rockbox-dsp dep (all now transitive). - New rockbox_player.rs (RockboxPlayer) implements Renderer by delegating to rockbox_playback::Player. Player owns a cpal stream and is !Send + !Sync, so it lives on a dedicated worker thread driven by FnOnce(&Player) command closures; the struct holds only the Sender + a Send+Sync metadata mirror. Delete symphonia_player.rs and voice_dsp.rs. - Persistence: the engine owns queue order + exact playhead via its own resume_file; fin's queue.json stays a metadata sidecar so the TUI keeps server-provided titles/artwork. restore() calls Player::resume() with a seed-from-sidecar fallback for first-run migration. - Slim replaygain.rs / crossfade.rs to re-exports of the fin-config types (tag extraction + fade curves now live in the engine). - Rewire lib.rs / local.rs and refresh docs; sweep stale "symphonia" mentions across fin, fin-tui and fin-mediarenderer. - flake.nix: add stdenv.cc to the package and dev shell — rockbox-codecs / rockbox-dsp compile Rockbox's C sources via the cc crate. Note: rockbox-playback is GPL-2.0-or-later, so linking it makes the fin binary GPL (already true via rockbox-dsp).
Update the workspace version, flake build version, README install URLs and the Debian/RPM packaging manifests from 0.5.0 to 0.6.0.
Document the symphonia → rockbox-playback audio backend swap and the GPL/stdenv.cc build note under a new 0.6.0 release section.
Add a "Supported audio formats" table (grouped lossless / lossy / PCM / game audio) covering the full rockbox-playback codec set, wire it into the table of contents, and refresh the remaining stale "symphonia" references throughout the README to point at rockbox-playback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.