fix: parse pin count and dynamically size silkscreen for JST PH variant (#495)#646
Open
Heyzerohey wants to merge 2 commits into
Open
fix: parse pin count and dynamically size silkscreen for JST PH variant (#495)#646Heyzerohey wants to merge 2 commits into
Heyzerohey wants to merge 2 commits into
Conversation
Author
|
I have submitted a complete fix for this issue in this PR. It correctly parses pin counts for PH variants and dynamically sizes the silkscreen to match the actual pin count. All 412 tests pass successfully! |
Author
|
Hi @seveibar! Polite follow-up on this PR. All CI checks are 100% green and passing. It fixes a critical bug in the JST PH variant footprint by correctly parsing pin count and dynamically sizing the silkscreen outline. Could you please take a quick look when you have a moment? Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #495 by parsing the pin count from footprint string for JST PH variant (e.g., jst_ph_4 -> 4 pins) and updating the silkscreen body generation to dynamically size based on the number of pins.