Skip to content

fix flaky test and correct clearEventListeners return type (#708) #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

fix flaky test and correct clearEventListeners return type (#708) #1264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/shared/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export type CircuitWebWorker = {
renderUntilSettled: () => Promise<void>
getCircuitJson: () => Promise<AnyCircuitElement[]>
on: (event: RootCircuitEventName, callback: (...args: any[]) => void) => void
clearEventListeners: () => void
clearEventListeners: () => Promise<void>
enableDebug: (namespace: string) => Promise<void>
version: () => Promise<string>
kill: () => Promise<void>
Expand Down
9 changes: 4 additions & 5 deletions tests/examples/example05-event-recording.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { test, expect } from "bun:test"
import { createCircuitWebWorker } from "lib/index"

// Skipped for flakiness, re-enable when flakiness is solved
test.skip("example5-event-recording", async () => {
test("example5-event-recording", async () => {
const circuitWebWorker = await createCircuitWebWorker({
webWorkerUrl: new URL("../../webworker/entrypoint.ts", import.meta.url),
})
Expand All @@ -22,11 +21,11 @@ test.skip("example5-event-recording", async () => {

await circuitWebWorker.renderUntilSettled()

// Clear event listeners
await circuitWebWorker.clearEventListeners()
expect(eventCount).toBeGreaterThan(0)
const initialEventCount = eventCount

// Clear event listeners
circuitWebWorker.clearEventListeners()
const initialEventCount = eventCount

// Add another component to trigger more events
await circuitWebWorker.execute(`
Expand Down