Proto update to support scanning confluence comments #4484
+1,200
−1,173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecodym
reviewed
Oct 3, 2025
proto/source_metadata.proto
Outdated
| string location = 7; | ||
| string file = 8; | ||
| string user = 9; | ||
| string comment = 10; |
There was a problem hiding this comment.
Unlike all the other fields, I can't form a good guess about what's stored in this just by reading its name. Is it a comment ID or something?
There was a problem hiding this comment.
It is the comment ID. I tried to make it consistent with other fields, but you're right, it should be clearer. I'll make the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the proto files to support scanning confluence comments.
Checklist:
make test-community)?make lintthis requires golangci-lint)?