NAS-121694 / None / Give more useful error message for ypwhich failure#262
Open
anodos325 wants to merge 1 commit intotruenas/13-stablefrom
Open
NAS-121694 / None / Give more useful error message for ypwhich failure#262anodos325 wants to merge 1 commit intotruenas/13-stablefrom
anodos325 wants to merge 1 commit intotruenas/13-stablefrom
Conversation
We should print out the RPC error message rather than only stating that the host is not boudn to a ypmaster. This will help support diagnose the actual underlying issue.
bugclerk
changed the title
amotin
approved these changes
Apr 26, 2023
Collaborator
amotin
left a comment
amotin
left a comment
There was a problem hiding this comment.
Never saw this code before, but makes sense on quick investigation.
Should we upstream it?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should print out the RPC error message rather than only stating that the host is not boudn to a ypmaster. This will help support diagnose the actual underlying issue.