Skip to content

PD-2255 / 25.10 / Pd 2255 update acme certificate content (by micjohnson777) #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 13, 2025
Merged

PD-2255 / 25.10 / Pd 2255 update acme certificate content (by micjohnson777) #4239

merged 8 commits into from
Nov 13, 2025

Conversation

@bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Oct 22, 2025

Automatic cherry-pick failed. Please resolve conflicts by running:

git cherry-pick -x a5897b9f3f3e3d4a2b9a6df20a7400a9a62f97cb
git cherry-pick -x 993da849bd813cdac65e186821ed51f8252773ab
git cherry-pick -x 07863c636e3bfafee5a5d1eadc710cf125cd35f8
git cherry-pick -x 78ac104ba586eec4ff8651db1aa6312b3369d979

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x b5ed0c27f03bb16f33cea7afa2fcd34e498b7b82

This PR updates the content in the ACME DNS Authenticator and CSR tutorials to show correct information on adding the ACME DNS authenticator, adding a CSR, and creating an ACME certificate for the CSR.
It also updates the CredentialsCertificatesScreen.png to show each widget with added items.

Backports to 25.10

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

Original PR: #4230
Jira URL: https://ixsystems.atlassian.net/browse/PD-2255

@micjohnson777 @bugclerk
PD-2255 Update AddACMESCALE.md Content
dde1319 
This commit updates the instructions in the AddACMESCALE.md tutorial.

(cherry picked from commit 0eded74)
@github-actions
Copy link

github-actions bot commented Oct 22, 2025 •
edited
Loading

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 18 issues found in changed files - 1 errors, 0 warnings, 17 suggestions

Changed files with issues:

content/SCALETutorials/Credentials/Certificates/AddACMESCALE.md (18 issues)

  • Lines 2, 15, 19, 22, 27, 32, 54, 56, 68 - suggestion: Spell out 'ACME' on first use
  • Line 19 - suggestion: Spell out 'AWS' on first use
  • Line 26 - error: Use 'login' instead of 'log in'
  • Line 26 - suggestion: Use 'login' instead of 'log in'
  • Line 50 - suggestion: Spell out 'OVH' on first use
  • Line 62 - suggestion: Use active voice instead of passive voice

🔧 To fix: Review the issues above and update your documentation accordingly.

@micjohnson777 micjohnson777 marked this pull request as ready for review October 31, 2025 14:57
@micjohnson777 micjohnson777 requested a review from a team as a code owner October 31, 2025 14:57
@github-actions
Copy link

github-actions bot commented Oct 31, 2025 •
edited
Loading

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 18 issues found in changed files - 1 errors, 0 warnings, 17 suggestions

Changed files with issues:

content/SCALETutorials/Credentials/Certificates/AddACMESCALE.md (18 issues)

  • Lines 2, 15, 19, 22, 27, 32, 54, 56, 68 - suggestion: Spell out 'ACME' on first use
  • Line 19 - suggestion: Spell out 'AWS' on first use
  • Line 26 - suggestion: Use 'login' instead of 'log in'
  • Line 26 - error: Use 'login' instead of 'log in'
  • Line 50 - suggestion: Spell out 'OVH' on first use
  • Line 62 - suggestion: Use active voice instead of passive voice

🔧 To fix: Review the issues above and update your documentation accordingly.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 18 issues found in changed files - 1 errors, 0 warnings, 17 suggestions

Changed files with issues:

content/SCALETutorials/Credentials/Certificates/AddACMESCALE.md (18 issues)

  • Lines 2, 15, 19, 22, 27, 32, 54, 56, 68 - suggestion: Spell out 'ACME' on first use
  • Line 19 - suggestion: Spell out 'AWS' on first use
  • Line 26 - suggestion: Use 'login' instead of 'log in'
  • Line 26 - error: Use 'login' instead of 'log in'
  • Line 50 - suggestion: Spell out 'OVH' on first use
  • Line 62 - suggestion: Use active voice instead of passive voice

🔧 To fix: Review the issues above and update your documentation accordingly.

@DjP-iX
Copy link
Contributor

DjP-iX commented Nov 12, 2025

@micjohnson777 are you sure this one is ready to go? The original PR had 3 files changed and this has only 1. Bugclerk might have gotten blocked on the backport?

micjohnson777 and others added 5 commits November 13, 2025 12:21
@micjohnson777 @linzi-ix
PD-2255 / 26.04 / Pd 2255 update acme certificate content (#4230)
1b94260 
* PD-2255 Update AddACMESCALE.md Content

This commit updates the instructions in the AddACMESCALE.md tutorial.

* PD-2255 UpdateAddCSRsSCALE.md

This commit updates the tutorial for adding a CSR and ACME Certificate.

* PD-2255 Update the CredentialsCertificatesScreen.png

This commit changes the image to show each widget populated (certificate, csr, and acme dns authenticator)

* Update AddCSRsSCALE.md

---------

Co-authored-by: linzibelle <[email protected]>
(cherry picked from commit b5ed0c2)
@micjohnson777
Merge branch 'PD-2255-25.10' of https://github.com/truenas/documentation
93bfa14 
 into PD-2255-25.10
@micjohnson777
Merge branch '25.10' into PD-2255-25.10
a8462bf
@micjohnson777
PD-2255 Changes missing in the 25.10 backport
1fac6e0 
This commit makes the changes to the AddCSRsSCALE.md tutorial missing from the bugclerk backport
@micjohnson777
Merge branch 'PD-2255-25.10' of https://github.com/truenas/documentation
8220d8c 
 into PD-2255-25.10
@github-actions
Copy link

github-actions bot commented Nov 13, 2025 •
edited
Loading

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 43 issues found in changed files - 3 errors, 0 warnings, 40 suggestions

Changed files with issues:

content/SCALETutorials/Credentials/Certificates/AddCSRsSCALE.md (25 issues)

  • Lines 20, 24, 96 - suggestion: Keep sentences under 30 words
  • Lines 20, 22, 28, 58, 89, 92, 93, 108 - suggestion: Spell out 'ACME' on first use
  • Lines 22, 93, 102 - suggestion: Use active voice instead of passive voice
  • Lines 24, 96 - error: Don't add '(s)' to a singular noun. Use plural instead.
  • Line 87 - suggestion: Spell out 'ACNE' on first use
  • Line 108 - suggestion: Spell out 'URI' on first use

content/SCALETutorials/Credentials/Certificates/AddACMESCALE.md (18 issues)

  • Lines 2, 15, 19, 22, 27, 32, 54, 56, 68 - suggestion: Spell out 'ACME' on first use
  • Line 19 - suggestion: Spell out 'AWS' on first use
  • Line 26 - suggestion: Use 'login' instead of 'log in'
  • Line 26 - error: Use 'login' instead of 'log in'
  • Line 50 - suggestion: Spell out 'OVH' on first use
  • Line 62 - suggestion: Use active voice instead of passive voice

🔧 To fix: Review the issues above and update your documentation accordingly.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 13, 2025 •
edited
Loading

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 43 issues found in changed files - 3 errors, 0 warnings, 40 suggestions

Changed files with issues:

content/SCALETutorials/Credentials/Certificates/AddCSRsSCALE.md (25 issues)

  • Lines 20, 24, 96 - suggestion: Keep sentences under 30 words
  • Lines 20, 22, 28, 58, 89, 92, 93, 108 - suggestion: Spell out 'ACME' on first use
  • Lines 22, 93, 102 - suggestion: Use active voice instead of passive voice
  • Lines 24, 96 - error: Don't add '(s)' to a singular noun. Use plural instead.
  • Line 87 - suggestion: Spell out 'ACNE' on first use
  • Line 108 - suggestion: Spell out 'URI' on first use

content/SCALETutorials/Credentials/Certificates/AddACMESCALE.md (18 issues)

  • Lines 2, 15, 19, 22, 27, 32, 54, 56, 68 - suggestion: Spell out 'ACME' on first use
  • Line 19 - suggestion: Spell out 'AWS' on first use
  • Line 26 - suggestion: Use 'login' instead of 'log in'
  • Line 26 - error: Use 'login' instead of 'log in'
  • Line 50 - suggestion: Spell out 'OVH' on first use
  • Line 62 - suggestion: Use active voice instead of passive voice

🔧 To fix: Review the issues above and update your documentation accordingly.

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Vale Style Guide Issues

📊 Summary: 46 issues found in changed files - 3 errors, 0 warnings, 43 suggestions

Changed files with issues:

content/SCALETutorials/Credentials/Certificates/AddCSRsSCALE.md (28 issues)

  • Lines 20, 26, 98 - suggestion: Keep sentences under 30 words
  • Lines 20, 22, 24, 30, 60, 91, 94, 95, 110 - suggestion: Spell out 'ACME' on first use
  • Lines 22, 24, 95, 104 - suggestion: Use active voice instead of passive voice
  • Lines 26, 98 - error: Don't add '(s)' to a singular noun. Use plural instead.
  • Line 89 - suggestion: Spell out 'ACNE' on first use
  • Line 110 - suggestion: Spell out 'URI' on first use

content/SCALETutorials/Credentials/Certificates/AddACMESCALE.md (18 issues)

  • Lines 2, 15, 19, 22, 27, 32, 54, 56, 68 - suggestion: Spell out 'ACME' on first use
  • Line 19 - suggestion: Spell out 'AWS' on first use
  • Line 26 - error: Use 'login' instead of 'log in'
  • Line 26 - suggestion: Use 'login' instead of 'log in'
  • Line 50 - suggestion: Spell out 'OVH' on first use
  • Line 62 - suggestion: Use active voice instead of passive voice

🔧 To fix: Review the issues above and update your documentation accordingly.

@DjP-iX DjP-iX merged commit 3f72574 into 25.10 Nov 13, 2025
4 checks passed
@DjP-iX DjP-iX deleted the PD-2255-25.10 branch November 13, 2025 18:21
@bugclerk
Copy link
Contributor Author

bugclerk commented Nov 13, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DjP-iX DjP-iX DjP-iX approved these changes

Assignees

@micjohnson777 micjohnson777

Labels

Re-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bugclerk @DjP-iX @micjohnson777